From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH v3] ethdev: silence error message on rte_eth_dev_owner_unset Date: Tue, 21 Aug 2018 08:45:15 -0700 Message-ID: <20180821084515.2a802429@xeon-e3> References: <20180814001926.19630-1-stephen@networkplumber.org> <20180816224409.5719-1-stephen@networkplumber.org> <20180816224409.5719-2-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: matan@mellanox.com Return-path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id A098098 for ; Tue, 21 Aug 2018 17:45:18 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id a11-v6so8640131pgw.6 for ; Tue, 21 Aug 2018 08:45:18 -0700 (PDT) In-Reply-To: <20180816224409.5719-2-stephen@networkplumber.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" =46rom 74ad4c60262b1451a5a2fabf79a2df89c6c5373d Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 16 Aug 2018 15:37:14 -0700 Subject: [PATCH 1/5] ethdev: silence error message on rte_eth_dev_owner_uns= et The rte_eth_dev_owner_unset function always generates a log message because the unset value for owner id is 0. Also, when rte_eth_dev_owner_delete is called with a valid owner id, the log message should be at NOTICE not ERROR severity. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Signed-off-by: Stephen Hemminger --- v3 - handle rte_eth_dev_owner_delete leave other cleanups to later patch series lib/librte_ethdev/rte_ethdev.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 4c320250589a..56dd9c2e83d9 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -393,11 +393,8 @@ static int rte_eth_is_valid_owner_id(uint64_t owner_id) { if (owner_id =3D=3D RTE_ETH_DEV_NO_OWNER || - rte_eth_dev_shared_data->next_owner_id <=3D owner_id) { - RTE_ETHDEV_LOG(ERR, "Invalid owner_id=3D%016"PRIx64"\n", - owner_id); + rte_eth_dev_shared_data->next_owner_id <=3D owner_id) return 0; - } return 1; } =20 @@ -444,8 +441,12 @@ _rte_eth_dev_owner_set(const uint16_t port_id, const u= int64_t old_owner_id, } =20 if (!rte_eth_is_valid_owner_id(new_owner->id) && - !rte_eth_is_valid_owner_id(old_owner_id)) + !rte_eth_is_valid_owner_id(old_owner_id)) { + RTE_ETHDEV_LOG(ERR, + "Invalid owner old_id=3D%016"PRIx64" new_id=3D%016"PRIx64"\n", + old_owner_id, new_owner->id); return -EINVAL; + } =20 port_owner =3D &rte_eth_devices[port_id].data->owner; if (port_owner->id !=3D old_owner_id) { @@ -516,9 +517,13 @@ rte_eth_dev_owner_delete(const uint64_t owner_id) if (rte_eth_devices[port_id].data->owner.id =3D=3D owner_id) memset(&rte_eth_devices[port_id].data->owner, 0, sizeof(struct rte_eth_dev_owner)); - RTE_ETHDEV_LOG(ERR, + RTE_ETHDEV_LOG(NOTICE, "All port owners owned by %016"PRIx64" identifier have removed\n", owner_id); + } else { + RTE_ETHDEV_LOG(ERR, + "Invalid owner id=3D%016"PRIx64"\n", + owner_id); } =20 rte_spinlock_unlock(&rte_eth_dev_shared_data->ownership_lock); --=20 2.18.0