From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id
	return bool
Date: Tue, 21 Aug 2018 11:31:29 -0700
Message-ID: <20180821113129.6e7e680e@xeon-e3>
References: <20180814001926.19630-1-stephen@networkplumber.org>
 <20180816224409.5719-1-stephen@networkplumber.org>
 <20180816224409.5719-3-stephen@networkplumber.org>
 <AM0PR0502MB40196B5CB58E7B2E123FF037D2310@AM0PR0502MB4019.eurprd05.prod.outlook.com>
 <20180821080644.306bba69@xeon-e3>
 <AM0PR0502MB4019294B474E1AD6810B0190D2310@AM0PR0502MB4019.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <sthemmin@microsoft.com>
To: Matan Azrad <matan@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl0-f68.google.com (mail-pl0-f68.google.com
 [209.85.160.68]) by dpdk.org (Postfix) with ESMTP id 524653DC
 for <dev@dpdk.org>; Tue, 21 Aug 2018 20:31:32 +0200 (CEST)
Received: by mail-pl0-f68.google.com with SMTP id b90-v6so9187482plb.0
 for <dev@dpdk.org>; Tue, 21 Aug 2018 11:31:32 -0700 (PDT)
In-Reply-To: <AM0PR0502MB4019294B474E1AD6810B0190D2310@AM0PR0502MB4019.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 21 Aug 2018 15:48:19 +0000
Matan Azrad <matan@mellanox.com> wrote:

> Hi
> 
> From: Stephen Hemminger
> > On Tue, 21 Aug 2018 10:20:43 +0000
> > Matan Azrad <matan@mellanox.com> wrote:
> >   
> > > From: Stephen Hemminger  
> > > > Function is boolean so use that.  
> > >
> > > Ethdev is not using bool type, see also:
> > > rte_eth_dev_is_valid_port
> > > rte_eth_dev_is_removed
> > > rte_eth_dev_pool_ops_supported
> > >
> > > I think it should be a full solution to all.
> > >  
> > > > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>  
> > 
> > I didn't want change type of visible (exported by ABI) functions.
> >   
> Since ethdev now is not using bool type I think it's better not to change it only for this API.

I hate to pick nits but there is already a bool usage in internal
function (static) in ethdev.


static bool
is_allocated(const struct rte_eth_dev *ethdev)
{
	return ethdev->data->name[0] != '\0';
}

Using bool functions doesn't really generate different code. It is is more
about using modern C conventions.