From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH v2 4/4] eventdev: add auto test for eth Tx
	adapter
Date: Wed, 22 Aug 2018 21:53:09 +0530
Message-ID: <20180822162307.GA18299@ltp-pvn>
References: <1534479652-80182-1-git-send-email-nikhil.rao@intel.com>
 <1534479652-80182-4-git-send-email-nikhil.rao@intel.com>
 <20180817115515.GA4360@ltp-pvn>
 <6cd55ea9-fb68-73a4-43bd-dcd6772247cf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: "Rao, Nikhil" <nikhil.rao@intel.com>, jerin.jacob@caviumnetworks.com,
 olivier.matz@6wind.com
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0069.outbound.protection.outlook.com [104.47.41.69])
 by dpdk.org (Postfix) with ESMTP id 713043772
 for <dev@dpdk.org>; Wed, 22 Aug 2018 18:26:26 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <6cd55ea9-fb68-73a4-43bd-dcd6772247cf@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Aug 22, 2018 at 09:43:02PM +0530, Rao, Nikhil wrote:
> > > +       ev_qid = qcnt;
> > > +       qconf.nb_atomic_flows = dev_info.max_event_queue_flows;
> > > +       qconf.nb_atomic_order_sequences = 32;
> > > +       qconf.schedule_type = RTE_SCHED_TYPE_ATOMIC;
> > > +       qconf.priority = RTE_EVENT_DEV_PRIORITY_HIGHEST;
> > > +       qconf.event_queue_cfg = RTE_EVENT_QUEUE_CFG_SINGLE_LINK;
> > > +       err = rte_event_queue_setup(TEST_DEV_ID, ev_qid, &qconf);
> > > +       TEST_ASSERT_SUCCESS(err, "Failed to setup queue %u", ev_qid);
> >
> > On reconfigure, setup all the ports and queues so that the newly configured
> > values are seen by them.
>
> Is that required since dev_conf matches dev_info except for the number
> of queues ?

Some drivers require this as without port setup newly configured queues might
not be visible.

>
> >
> > > +
> > > +       err = rte_event_port_link(TEST_DEV_ID, ev_port, &ev_qid, NULL, 1);
> > > +       TEST_ASSERT(err == 1, "Failed to link queue port %u",
> > > +                   ev_port);
> > > +
> > > +       err = rte_event_eth_tx_adapter_start(TEST_INST_ID);
> > > +       TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> > > +
> > > +       err = rte_event_dev_service_id_get(0, &eid);
> > > +       TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> >
> > An event device might not be needing a service core, check the capabilities
> > before requesting service id above.
> >
>
> The internal_port capability is checked at the beginning of the
> function, if its not set, I think its Ok to assume that we need a
> service core ?

That check is to see if TX adapter requires service core, the above one is
checking if eventdev requires serivce core.

>
> Thanks,
> Nikhil
>

Regards,
Pavan.