From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] ethdev: fix rte_eth_dev_owner_unset
Date: Fri, 24 Aug 2018 07:42:36 -0700
Message-ID: <20180824074236.7f979884@xeon-e3>
References: <20180814001926.19630-1-stephen@networkplumber.org>
 <AM0PR0502MB4019D2C8D2486AEDF7B95734D2380@AM0PR0502MB4019.eurprd05.prod.outlook.com>
 <20180814095521.492e575a@xeon-e3>
 <DB3PR0502MB40281C9B5A11F17D0231108DD2380@DB3PR0502MB4028.eurprd05.prod.outlook.com>
 <fc0f9714-1928-9c3a-dd89-7d7f1e97726d@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Matan Azrad <matan@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com
 [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id E3C315B3E
 for <dev@dpdk.org>; Fri, 24 Aug 2018 16:42:43 +0200 (CEST)
Received: by mail-pl1-f194.google.com with SMTP id x6-v6so1189474plv.10
 for <dev@dpdk.org>; Fri, 24 Aug 2018 07:42:43 -0700 (PDT)
In-Reply-To: <fc0f9714-1928-9c3a-dd89-7d7f1e97726d@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 24 Aug 2018 14:55:56 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 8/14/2018 8:46 PM, Matan Azrad wrote:
> > Hi Stephen
> > 
> > From: Stephen Hemminger  
> >> On Tue, 14 Aug 2018 05:52:20 +0000
> >> Matan Azrad <matan@mellanox.com> wrote:
> >>  
> >>> Hi Stephen
> >>>
> >>> From: Stephen Hemminger  
> >>>> The rte_eth_dev_owner_unset function is unusable because it always
> >>>> returns -EINVAL. This is because the magic (unowned) value is
> >>>> flagged as not valid.
> >>>>  
> >>>
> >>> It's OK to raise an error when you do unset for unowned device.
> >>> It means that unset owner should be called for owned device.
> >>>  
> >>
> >> Original code was broken. The following would always fail.
> >>
> >> 	rte_eth_dev_owner_new(&owner.id);
> >> 	sprintf(owner.name, "example");
> >> 	rte_eth_dev_owner_set(port_id, &owner);
> >> 	rte_eth_dev_owner_unset(port_id, owner.id);
> >>
> >> That is because of:
> >> 	rte_eth_dev_owner_unset(port_id, owner_id)
> >> 		_rte_eth_dev_owner_set(port_id, owner_id, &new_owner)
> >> << new_owner.id == RTE_ETH_DEV_NO_OWNER (0)
> >>
> >>
> >> 	if (!rte_eth_is_valid_owner_id(new_owner->id) &&  <<
> >> new_owner->id == RTE_ETH_DEV_NO_OWNER (which is flagged as invalid)
> >> 	    !rte_eth_is_valid_owner_id(old_owner_id))
> >> 		return -EINVAL;
> >>  
> > 
> > But both should be invalid the new owner and the old owner(&&) to raise an EINVAL error.
> > 
> > In the aforementioned check above the old owner should be valid.  
> 
> It looks rte_eth_dev_owner_unset() works, updating patch as rejected.
> 

The issue was the incorrect log message, addressed in later patches.