From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH 1/6] drivers/common: add mvep common code for
 MRVL PMDs
Date: Fri, 24 Aug 2018 14:49:29 +0200
Message-ID: <20180824124929.GA12044@sh>
References: <1535113006-9393-1-git-send-email-tdu@semihalf.com>
 <1535113006-9393-2-git-send-email-tdu@semihalf.com>
 <a1a4a011-9710-5418-c2fa-1681a5f58f3d@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org, nsamsono@marvell.com,
 mw@semihalf.com, Liron Himi <lironh@marvell.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 55F7F2C4F
 for <dev@dpdk.org>; Fri, 24 Aug 2018 14:49:31 +0200 (CEST)
Received: by mail-lj1-f193.google.com with SMTP id y17-v6so6784398ljy.8
 for <dev@dpdk.org>; Fri, 24 Aug 2018 05:49:31 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <a1a4a011-9710-5418-c2fa-1681a5f58f3d@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Aug 24, 2018 at 01:32:47PM +0100, Ferruh Yigit wrote:
> On 8/24/2018 1:16 PM, Tomasz Duszynski wrote:
> > From: Liron Himi <lironh@marvell.com>
> >
> > Add MVEP (Marvell Embedded Processors) to drivers/common which
> > will keep code reused by current and future MRVL PMDs.
> > Right now we have only common DMA memory initialization routines there.
> >
> > Signed-off-by: Liron Himi <lironh@marvell.com>
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
> > ---
> >  config/common_base                              |  5 +++
> >  devtools/test-build.sh                          |  2 ++
> >  drivers/common/Makefile                         |  4 +++
> >  drivers/common/meson.build                      |  2 +-
> >  drivers/common/mvep/Makefile                    | 38 +++++++++++++++++=
++++
> >  drivers/common/mvep/meson.build                 | 19 +++++++++++
> >  drivers/common/mvep/mvep_common.c               | 45 +++++++++++++++++=
++++++++
> >  drivers/common/mvep/rte_common_mvep_version.map |  6 ++++
> >  drivers/common/mvep/rte_mvep_common.h           | 20 +++++++++++
> >  mk/rte.app.mk                                   |  4 +++
> >  10 files changed, 144 insertions(+), 1 deletion(-)
> >  create mode 100644 drivers/common/mvep/Makefile
> >  create mode 100644 drivers/common/mvep/meson.build
> >  create mode 100644 drivers/common/mvep/mvep_common.c
> >  create mode 100644 drivers/common/mvep/rte_common_mvep_version.map
> >  create mode 100644 drivers/common/mvep/rte_mvep_common.h
> >
> > diff --git a/config/common_base b/config/common_base
> > index 4bcbaf9..978592d 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -395,6 +395,11 @@ CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=3Dn
> >  CONFIG_RTE_LIBRTE_PMD_FAILSAFE=3Dy
> >
> >  #
> > +# Compile Marvell Embedded Processors Common
> > +#
> > +CONFIG_RTE_LIBRTE_MVEP_COMMON=3Dn
>
> Do you need a new config option for common, why not enable it if one of t=
he
> consumers of common code enabled?

Good point. Will rework that in v2.

--
- Tomasz Duszy=C5=84ski