From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH v2 2/6] net/mvpp2: use common code to
 initialize DMA
Date: Fri, 24 Aug 2018 19:51:13 +0200
Message-ID: <20180824175113.GA32439@sh>
References: <1535113006-9393-1-git-send-email-tdu@semihalf.com>
 <1535122494-30249-1-git-send-email-tdu@semihalf.com>
 <1535122494-30249-3-git-send-email-tdu@semihalf.com>
 <1d3a475c-1111-1ccc-d365-bfce148fc8f8@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org, nsamsono@marvell.com,
 mw@semihalf.com, Liron Himi <lironh@marvell.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id CC5CF1AEEB
 for <dev@dpdk.org>; Fri, 24 Aug 2018 19:51:14 +0200 (CEST)
Received: by mail-lj1-f196.google.com with SMTP id m84-v6so7481127lje.10
 for <dev@dpdk.org>; Fri, 24 Aug 2018 10:51:14 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1d3a475c-1111-1ccc-d365-bfce148fc8f8@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Aug 24, 2018 at 05:46:21PM +0100, Ferruh Yigit wrote:
> On 8/24/2018 3:54 PM, Tomasz Duszynski wrote:
> > From: Liron Himi <lironh@marvell.com>
> >
> > Use common code to initialize MUSDK DMA memory buffers.
> >
> > Signed-off-by: Liron Himi <lironh@marvell.com>
> > Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
>
> <...>
>
> > @@ -2653,24 +2651,17 @@ rte_pmd_mrvl_probe(struct rte_vdev_device *vdev)
> >  	if (mrvl_dev_num)
> >  		goto init_devices;
> >
> > -	MRVL_LOG(INFO, "Perform MUSDK initializations");
> > -	/*
> > -	 * ret =3D=3D -EEXIST is correct, it means DMA
> > -	 * has been already initialized (by another PMD).
> > -	 */
> > -	ret =3D mv_sys_dma_mem_init(MRVL_MUSDK_DMA_MEMSIZE);
> > -	if (ret < 0) {
> > -		if (ret !=3D -EEXIST)
> > -			goto out_free_kvlist;
> > -		else
> > -			MRVL_LOG(INFO,
> > -				"DMA memory has been already initialized by a different driver.");
> > -	}
> > +	MRVL_LOG(INFO, "Perform MUSDK initializations\n");
>
> MRVL_LOG already adding "\n", no need to change original log, a few more =
below.

Good catch.

--
- Tomasz Duszy=C5=84ski