From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH v3] net/virtio-user: check negotiated
	features before set
Date: Thu, 30 Aug 2018 13:20:14 +0800
Message-ID: <20180830052014.GA84594@fbsd.sh.intel.com>
References: <1535558121-10034-1-git-send-email-eric.zhang@windriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org,
 Allain.Legacy@windriver.com, Matt.Peters@windriver.com
To: eric zhang <eric.zhang@windriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 31341F11
 for <dev@dpdk.org>; Thu, 30 Aug 2018 07:22:34 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1535558121-10034-1-git-send-email-eric.zhang@windriver.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Aug 29, 2018 at 11:55:21AM -0400, eric zhang wrote:
> This patch checks negotiated features to see if necessary to offload
> before set the tap device offload capabilities. It also checks if kernel
> support the TUNSETOFFLOAD operation.

Fixes: 5e97e4202563 ("net/virtio-user: enable offloading")
Cc: stable@dpdk.org

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks!

> 
> Signed-off-by: eric zhang <eric.zhang@windriver.com>
> 
> ---
> v3:
> * make other offloading features depend on CSUM
> * check IFF_VNET_HDR support when handling VHOST_GET_FEATURES
> 
> ---
> v2:
> * don't return failure when failed to set offload to tap
> * check if offloads available when handling VHOST_GET_FEATURES
> ---
>  drivers/net/virtio/virtio_user/vhost_kernel.c     | 18 +++++---
>  drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 56 +++++++++++++++++------
>  drivers/net/virtio/virtio_user/vhost_kernel_tap.h |  2 +-
>  3 files changed, 54 insertions(+), 22 deletions(-)
>