From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v1 1/7] examples/power: add checks around
 hypervisor
Date: Thu, 30 Aug 2018 09:59:39 -0700
Message-ID: <20180830095535.1548db4f@xeon-e3>
References: <20180830105422.1198-1-david.hunt@intel.com>
 <20180830105422.1198-2-david.hunt@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, john.mcnamara@intel.com
To: David Hunt <david.hunt@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com
 [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 934E558FE
 for <dev@dpdk.org>; Thu, 30 Aug 2018 18:59:42 +0200 (CEST)
Received: by mail-pf1-f194.google.com with SMTP id i26-v6so4141023pfo.12
 for <dev@dpdk.org>; Thu, 30 Aug 2018 09:59:42 -0700 (PDT)
In-Reply-To: <20180830105422.1198-2-david.hunt@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 30 Aug 2018 11:54:16 +0100
David Hunt <david.hunt@intel.com> wrote:

Minor nits

> +static unsigned int global_hypervisor_available;

Please use bool for boolean values.

>  /*
>   * Represents a single Virtual Machine
> @@ -198,7 +199,11 @@ get_pcpus_mask(struct channel_info *chan_info, unsigned vcpu)
>  {
>  	struct virtual_machine_info *vm_info =
>  			(struct virtual_machine_info *)chan_info->priv_info;
> -	return rte_atomic64_read(&vm_info->pcpu_mask[vcpu]);
> +
> +	if ((global_hypervisor_available) && (vm_info != NULL))


 parenthesis are unnecessary here.

I know this is pre-existing, but please don't use CamelCase:

+		if (virNodeGetInfo(global_vir_conn_ptr, &info)) {