From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v1 11/13] bus/pci: process declarative PCI
 devargs
Date: Thu, 30 Aug 2018 18:37:32 +0200
Message-ID: <20180830163732.cv7hkmnuwqf3hurt@bidouze.vm.6wind.com>
References: <cover.1535633783.git.gaetan.rivet@6wind.com>
 <1cd54c876b80f441c483a2f43c1c1fba219b9237.1535633784.git.gaetan.rivet@6wind.com>
 <20180830091518.416c3ee4@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com
 [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id B2BE7532C
 for <dev@dpdk.org>; Thu, 30 Aug 2018 18:37:49 +0200 (CEST)
Received: by mail-wr1-f66.google.com with SMTP id 20-v6so8643535wrb.12
 for <dev@dpdk.org>; Thu, 30 Aug 2018 09:37:49 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180830091518.416c3ee4@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Aug 30, 2018 at 09:15:18AM -0700, Stephen Hemminger wrote:
> On Thu, 30 Aug 2018 15:42:02 +0200
> Gaetan Rivet <gaetan.rivet@6wind.com> wrote:
> 
> > +int
> > +rte_pci_devargs_process(struct rte_pci_device *pdev)
> > +{
> > +	/* For the moment, no PCI param
> > +	 * needs to be processed.
> > +	 */
> > +	(void) pdev;
> > +	return 0;
> > +}
> 
> Use __rte_unused rather than the (void) cast?

Ok.

I was wondering whether we should keep this patch.
Its only use is to mark the proper place where this function,
once it has become needed, would need to be called.

PCI bus does not have any parameters configuring devices, this function
will only be needed once some have been added.

-- 
Gaëtan Rivet
6WIND