From mboxrd@z Thu Jan  1 00:00:00 1970
From: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Subject: [PATCH v2] eal/bus: use RTE_IOVA_PA only if phys
	addresses are available
Date: Fri,  7 Sep 2018 17:58:43 +0200
Message-ID: <20180907155843.96465-1-dariusz.stojaczyk@intel.com>
References: <20180907154703.83316-1-dariusz.stojaczyk@intel.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
 Anatoly Burakov <anatoly.burakov@intel.com>, Chas Williams <chas3@att.com>,
 Darek Stojaczyk <dariusz.stojaczyk@intel.com>
To: dev@dpdk.org, Santosh Shukla <santosh.shukla@caviumnetworks.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 9DA1C493D
 for <dev@dpdk.org>; Fri,  7 Sep 2018 18:00:33 +0200 (CEST)
In-Reply-To: <20180907154703.83316-1-dariusz.stojaczyk@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

When neither RTE_IOVA_VA nor RTE_IOVA_PA was explicitly
requested, DPDK would currently fallback to the default
RTE_IOVA_PA mode and possibly encounter a failure later
on if running as a non-priviledged user. Attempting to
use RTE_IOVA_VA if no phys addresses are available may
help in this case.

Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
---
Changes since v1:
 * added a missing rte_memory.h include

 lib/librte_eal/common/eal_common_bus.c | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c
index 0943851cc..68c581b8a 100644
--- a/lib/librte_eal/common/eal_common_bus.c
+++ b/lib/librte_eal/common/eal_common_bus.c
@@ -37,6 +37,7 @@
 #include <rte_bus.h>
 #include <rte_debug.h>
 #include <rte_string_fns.h>
+#include <rte_memory.h>
 
 #include "eal_private.h"
 
@@ -236,9 +237,19 @@ rte_bus_get_iommu_class(void)
 			mode |= bus->get_iommu_class();
 	}
 
-	if (mode != RTE_IOVA_VA) {
-		/* Use default IOVA mode */
-		mode = RTE_IOVA_PA;
+	if (mode == RTE_IOVA_VA)
+		return RTE_IOVA_VA;
+
+	if (mode & RTE_IOVA_PA) {
+		/* Not all buses support RTE_IOVA_VA, fallback to RTE_IOVA_PA */
+		return RTE_IOVA_PA;
+	}
+
+	if (rte_eal_using_phys_addrs()) {
+		/* Default to RTE_IOVA_PA only if it's supported */
+		return RTE_IOVA_PA;
 	}
-	return mode;
+
+	/* Since RTE_IOVA_PA is unsupported, fallback to RTE_IOVA_VA */
+	return RTE_IOVA_VA;
 }
-- 
2.17.1