From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] app/testpmd: add commands for TM to mark pkts
Date: Mon, 10 Sep 2018 21:09:39 +0530
Message-ID: <20180910153938.GA20620@jerin>
References: <20180817113919.32095-1-krzysztof.kanas@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Jerin.JacobKollanukkaran@cavium.com,
 Nithin.Dabilpuram@cavium.com, wenzhuo.lu@intel.com,
 jingjing.wu@intel.com, bernard.iremonger@intel.com,
 cristian.dumitrescu@intel.com
To: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0085.outbound.protection.outlook.com [104.47.32.85])
 by dpdk.org (Postfix) with ESMTP id 7634E4C9D
 for <dev@dpdk.org>; Mon, 10 Sep 2018 17:40:01 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180817113919.32095-1-krzysztof.kanas@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 17 Aug 2018 13:39:19 +0200
> From: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com>
> To: dev@dpdk.org
> Cc: krzysztof.kanas@caviumnetworks.com,
>  Jerin.JacobKollanukkaran@cavium.com, Nithin.Dabilpuram@cavium.com
> Subject: [dpdk-dev] [PATCH] app/testpmd: add commands for TM to mark pkts
> X-Mailer: git-send-email 2.18.0
> 
> Add following testpmd run-time commands to support test of TM packet
> marking:
> 
> set port tm mark ip_ecn   <port_id> <green> <yellow> <red>
> set port tm mark ip_dscp  <port_id> <green> <yellow> <red>
> set port tm mark vlan_dei <port_id> <green> <yellow> <red>
> 
> Signed-off-by: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com>
> ---
>  app/test-pmd/cmdline.c                      |   3 +
>  app/test-pmd/cmdline_tm.c                   | 260 ++++++++++++++++++++
>  app/test-pmd/cmdline_tm.h                   |   3 +

+ Cristian, Wenzhuo, Jingjing, Bernard 

In addition to this slow path change, IMO, we need test engine similar to
checksum(app/test-pmd/csumonly.c) to generate traffic(app/test-pmd/markonly.c) 
with struct rte_mbuf::tx_offload populated so that we can test the packet
marking.

Cristian,

Any thoughts as a rte_tm maintainer?