From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH v2 5/5] vhost: message handling implemented
 as a callback array
Date: Tue, 11 Sep 2018 09:51:17 +0800
Message-ID: <20180911015117.GA8195@debian>
References: <153202755842.21481.1772155561595981441.stgit@T460>
 <153202763503.21481.6074577075024787339.stgit@T460>
 <CGME20180910153230epcas5p28b552089ca3472806f4442e47a464543@epcas5p2.samsung.com>
 <1828a711-9db9-4408-c9e4-be49091e8be0@redhat.com>
 <20180910160804eucas1p22e18ba6128dd3b5592cbca5867784749~TFaI2BMkC1648416484eucas1p2G@eucas1p2.samsung.com>
 <cb341c2e-3b6d-0964-ad5e-d6b657244e7e@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: Ilya Maximets <i.maximets@samsung.com>,
 Nikolay Nikolaev <nicknickolaev@gmail.com>, zhihong.wang@intel.com,
 dev@dpdk.org
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 47EC04CA0
 for <dev@dpdk.org>; Tue, 11 Sep 2018 03:52:29 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <cb341c2e-3b6d-0964-ad5e-d6b657244e7e@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Sep 10, 2018 at 06:43:17PM +0200, Maxime Coquelin wrote:
> Hi Ilya,
> 
> On 09/10/2018 06:09 PM, Ilya Maximets wrote:
> > Hi Maxime,
> > Thanks for pointing to this patch set. I missed it somehow.
> > 
> > This patch could not replace mine [1], because it does not improve
> > the message handling from the error handling point of view. But
> > it completely changes the code, so we need to negotiate the order
> > in which they will be applied or combine them somehow.
> 
> By complementary I meant both of your patches add similar things, like
> vhost_user_set_vring_kick() becoming an int (even if Nikolay's version
> doesn't return an error for now).
> 
> > 
> > So, what's the plan? What do you think?
> 
> On one hand Nikolay's series was posted first, and it might be easier to
> just apply your patch on top. On the other hand, your patch fixes an
> issue, so it will be easier to backport it if it is applied first.
> 
> I guess we should go for your patch first to ease backporting.
> 
> I'd like Tiwei's feedback before applying anything, as he reviewed the
> first versions of both yours and Nikolay's patches.

I also incline to merge the fix patch first, as it needs
to be backported.

> 
> > Few comments inline.
> > 
> > [1] http://patchwork.dpdk.org/patch/44168/
[...]