From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hyong Youb Kim Subject: Re: [PATCH v2] ethdev: make default behavior CRC strip on Rx Date: Tue, 11 Sep 2018 17:05:35 +0900 Message-ID: <20180911080534.GA10096@HYONKIM-7R0DR.cisco.com> References: <20180903144501.31373-1-ferruh.yigit@intel.com> <20180904101257.61129-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Ferruh Yigit Return-path: Received: from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92]) by dpdk.org (Postfix) with ESMTP id 112C91041 for ; Tue, 11 Sep 2018 10:05:40 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20180904101257.61129-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 04, 2018 at 11:12:56AM +0100, Ferruh Yigit wrote: > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. > > Applications that require keeping CRC should check PMD capability first > and if it is supported can enable this feature by setting > DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure() [...] > diff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c > index 8d493ffed..abe004b24 100644 > --- a/drivers/net/enic/enic_res.c > +++ b/drivers/net/enic/enic_res.c > @@ -195,7 +195,6 @@ int enic_get_vnic_config(struct enic *enic) > enic->rx_offload_capa = > DEV_RX_OFFLOAD_SCATTER | > DEV_RX_OFFLOAD_JUMBO_FRAME | > - DEV_RX_OFFLOAD_CRC_STRIP | > DEV_RX_OFFLOAD_VLAN_STRIP | > DEV_RX_OFFLOAD_IPV4_CKSUM | > DEV_RX_OFFLOAD_UDP_CKSUM | For net/enic. Acked-by: Hyong Youb Kim