From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 04/21] net/atlantic: hw_atl register declarations Date: Tue, 11 Sep 2018 10:04:01 -0700 Message-ID: <20180911100402.581bdba9@xeon-e3> References: <1536333719-32155-1-git-send-email-igor.russkikh@aquantia.com> <1536333719-32155-5-git-send-email-igor.russkikh@aquantia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, pavel.belous@aquantia.com, Nadezhda.Krupnina@aquantia.com, Simon.Edelhaus@aquantia.com, Corey Melton , Ashish Kumar To: Igor Russkikh Return-path: Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 1E4C44C9F for ; Tue, 11 Sep 2018 19:04:10 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id f6-v6so11632388plo.1 for ; Tue, 11 Sep 2018 10:04:10 -0700 (PDT) In-Reply-To: <1536333719-32155-5-git-send-email-igor.russkikh@aquantia.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 7 Sep 2018 18:21:42 +0300 Igor Russkikh wrote: > +/* register address for bitfield imr_rx{r}_en */ > + static u32 itr_imr_rxren_adr[32] = { > + 0x00002100U, 0x00002100U, 0x00002104U, 0x00002104U, > + 0x00002108U, 0x00002108U, 0x0000210CU, 0x0000210CU, > + 0x00002110U, 0x00002110U, 0x00002114U, 0x00002114U, > + 0x00002118U, 0x00002118U, 0x0000211CU, 0x0000211CU, > + 0x00002120U, 0x00002120U, 0x00002124U, 0x00002124U, > + 0x00002128U, 0x00002128U, 0x0000212CU, 0x0000212CU, > + 0x00002130U, 0x00002130U, 0x00002134U, 0x00002134U, > + 0x00002138U, 0x00002138U, 0x0000213CU, 0x0000213CU > + }; > + Don't you want to make these data tables const?