From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH 07/15] net/liquidio: rename version map after library file name Date: Tue, 11 Sep 2018 14:06:15 +0100 Message-ID: <20180911130615.GA11744@bricha3-MOBL.ger.corp.intel.com> References: <20180910200415.8340-1-bluca@debian.org> <20180910200415.8340-8-bluca@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, keith.wiles@intel.com, roy.fan.zhang@intel.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com, rasesh.mody@cavium.com, harish.patil@cavium.com, shahed.shaikh@cavium.com, amr.mokhtar@intel.com, shijith.thotton@cavium.com, ssrinivasan@cavium.com, liang.j.ma@intel.com, peter.mccarthy@intel.com, jerin.jacob@caviumnetworks.com, maciej.czekaj@caviumnetworks.com, arybchenko@solarflare.com, antosh.shukla@caviumnetworks.com, ashish.gupta@cavium.com, yongwang@vmware.com, thomas@monjalon.net To: Luca Boccassi , t@bricha3-MOBL.ger.corp.intel.com Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 9B2594CA1 for ; Tue, 11 Sep 2018 15:06:22 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20180910200415.8340-8-bluca@debian.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote: > The library is called librte_pmd_lio, so rename the map file and set > the name in the meson file so that the built library names with meson > and legacy makefiles are the same > > Fixes: bad475c03fee ("net/liquidio: add to meson build") > Cc: stable@dpdk.org > > Signed-off-by: Luca Boccassi Rather than doing this renaming, can we instead add a symlink in the install phase to map the old name to the new one? I'd like to see the consistency of directory name, map filename and driver name enforced strictly in the build system. Having exceptions is a pain. /Bruce