From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] build: create relative symlinks for PMDs in
	libdir
Date: Thu, 13 Sep 2018 10:11:36 +0100
Message-ID: <20180913091135.GA20960@bricha3-MOBL.ger.corp.intel.com>
References: <20180912172134.21099-1-bluca@debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, tredaelli@redhat.com
To: Luca Boccassi <bluca@debian.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 475014F91
 for <dev@dpdk.org>; Thu, 13 Sep 2018 11:13:27 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180912172134.21099-1-bluca@debian.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Sep 12, 2018 at 06:21:34PM +0100, Luca Boccassi wrote:
> Add -r option to ln, otherwise the link will be absolute and contain
> the build path and break packaging among other things:
> 
> lrwxrwxrwx 1 bluca bluca     99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
>   -> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
>      drivers/librte_mempool_dpaa.so.1.1
> 
> With -r:
> 
> lrwxrwxrwx 1 bluca bluca     35 Sep 12 18:13 librte_pmd_zlib.so.1.1
>   -> dpdk/drivers/librte_pmd_zlib.so.1.1
> 
> Fixes: ed4d43d73e2b ("build: symlink drivers to library directory")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
>  buildtools/symlink-drivers-solibs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/buildtools/symlink-drivers-solibs.sh b/buildtools/symlink-drivers-solibs.sh
> index 803dfec491..9826c6ae37 100644
> --- a/buildtools/symlink-drivers-solibs.sh
> +++ b/buildtools/symlink-drivers-solibs.sh
> @@ -9,4 +9,4 @@
>  # parameters to script are paths relative to install prefix:
>  # 1. directory containing driver files e.g. lib64/dpdk/drivers
>  # 2. directory for installed regular libs e.g. lib64
> -ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
> +ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
> -- 

Acked-by: Bruce Richardson <bruce.richardson@intel.com>