From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 2/2] app/testpmd: use the generic function to
 dump packets
Date: Fri, 14 Sep 2018 12:05:11 +0530
Message-ID: <20180914063509.GA8298@jerin>
References: <1536739583-29166-1-git-send-email-rasland@mellanox.com>
 <1536739583-29166-2-git-send-email-rasland@mellanox.com>
 <CALwxeUt41TnYZAjd-VDvKozBapR98xdm1vumYz=FqvzHLJcDgw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Raslan Darawsheh <rasland@mellanox.com>,
 "Wu, Jingjing" <jingjing.wu@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org,
 Shahaf Shuler <shahafs@mellanox.com>, xuemingl@mellanox.com
To: David Marchand <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam01on0043.outbound.protection.outlook.com [104.47.34.43])
 by dpdk.org (Postfix) with ESMTP id AA1605681
 for <dev@dpdk.org>; Fri, 14 Sep 2018 08:38:04 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <CALwxeUt41TnYZAjd-VDvKozBapR98xdm1vumYz=FqvzHLJcDgw@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Thu, 13 Sep 2018 18:43:02 +0200
> From: David Marchand <david.marchand@6wind.com>
> To: Raslan Darawsheh <rasland@mellanox.com>
> Cc: "Wu, Jingjing" <jingjing.wu@intel.com>, Thomas Monjalon
>  <thomas@monjalon.net>, dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>,
>  xuemingl@mellanox.com
> Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function
>  to dump packets
> 
> 
> On Wed, Sep 12, 2018 at 10:06 AM, Raslan Darawsheh <rasland@mellanox.com> wrote:
> > use the generic function to dump packets for several forwarding
> > engines.
> 
> Rather than patching some engines, how about putting this in rx/tx callbacks ?

+1 to have zero performance impact on forward engines.

> A bit like something I sent earlier ?
> 
> http://patches.dpdk.org/patch/44465/
> 
> 
> --
> David Marchand