From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH] mbuf: remove deprecated segment free
	functions
Date: Mon, 17 Sep 2018 09:07:47 +0200
Message-ID: <20180917070747.ywy3362j6ers66hz@platinum>
References: <20180910051819.15528-1-david.marchand@6wind.com>
 <90cb6257-0571-b28e-acf5-badbb235a499@solarflare.com>
 <3144150.fCSgx81mNO@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Marchand <david.marchand@6wind.com>, dev@dpdk.org,
 Andrew Rybchenko <arybchenko@solarflare.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 2F99B2B84
 for <dev@dpdk.org>; Mon, 17 Sep 2018 09:07:52 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <3144150.fCSgx81mNO@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

On Sun, Sep 16, 2018 at 11:39:29AM +0200, Thomas Monjalon wrote:
> 10/09/2018 10:06, Andrew Rybchenko:
> > On 09/10/2018 08:18 AM, David Marchand wrote:
> > > __rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for
> > > a long time now (early 17.05), are not part of the abi and are easily
> > > replaced with existing api.
> > >
> > > Signed-off-by: David Marchand <david.marchand@6wind.com>
> > 
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 
> I think we need to bump the library version and update the API section
> in the release notes.

I don't think bumping the lib version is required here, the patch removes
two functions that are static inline.

But updating the API section would be nice, yes.

Thanks,
Olivier