From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 2/4] bnx2x: remove profanity
Date: Tue, 18 Sep 2018 08:07:15 -0700
Message-ID: <20180918080715.17fcd7d8@xeon-e3>
References: <20180725182019.31518-1-stephen@networkplumber.org>
 <20180725182019.31518-3-stephen@networkplumber.org>
 <3009159.xGyNxZp9MA@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>, Harish Patil
 <harish.patil@cavium.com>, Rasesh Mody <rasesh.mody@cavium.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com
 [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 7B8CA200
 for <dev@dpdk.org>; Tue, 18 Sep 2018 17:07:23 +0200 (CEST)
Received: by mail-pg1-f195.google.com with SMTP id s15-v6so1179407pgv.8
 for <dev@dpdk.org>; Tue, 18 Sep 2018 08:07:23 -0700 (PDT)
In-Reply-To: <3009159.xGyNxZp9MA@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 18 Sep 2018 11:40:28 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 25/07/2018 20:20, Stephen Hemminger:
> > No need for profanity in comments.
> > 
> > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> > ---
> >  drivers/net/bnx2x/elink.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
> > index 34a29373af3b..08fe817720a1 100644
> > --- a/drivers/net/bnx2x/elink.c
> > +++ b/drivers/net/bnx2x/elink.c
> > @@ -3993,11 +3993,11 @@ static elink_status_t elink_get_mod_abs_int_cfg(struct bnx2x_softc *sc,
> >  			   PORT_HW_CFG_E3_MOD_ABS_MASK) >>
> >  		    PORT_HW_CFG_E3_MOD_ABS_SHIFT;
> >  
> > -		/* Should not happen. This function called upon interrupt
> > +		/*
> > +		 * Should not happen. This function called upon interrupt
> >  		 * triggered by GPIO ( since EPIO can only generate interrupts
> >  		 * to MCP).
> >  		 * So if this function was called and none of the GPIOs was set,
> > -		 * it means the shit hit the fan.
> >  		 */  
> 
> It makes the comment ends with a comma, like the end is missing.
> 
> 
> 

Yes, better language would be.
		/* This should not happen since this function is called
		 * from interrupt triggered by GPI ..