From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] test/event: remove RSS config in eth Rx
	adapter test
Date: Thu, 20 Sep 2018 10:29:55 +0530
Message-ID: <20180920045952.GA2003@jerin>
References: <1536140526-7668-1-git-send-email-nikhil.rao@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, stable@dpdk.org
To: Nikhil Rao <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <1536140526-7668-1-git-send-email-nikhil.rao@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Wed, 5 Sep 2018 15:12:06 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> Subject: [PATCH] test/event: remove RSS config in eth Rx adapter test
> X-Mailer: git-send-email 1.8.3.1
> 
> External Email
> 
> Remove RSS config as it is not required (this also fixes an
> error with a hardcoded RSS config not supported by the NIC)
> 
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> CC: stable@dpdk.org
> ---
>  test/test/test_event_eth_rx_adapter.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
> index 2337e54..4cca77f 100644
> --- a/test/test/test_event_eth_rx_adapter.c
> +++ b/test/test/test_event_eth_rx_adapter.c
> @@ -117,13 +117,6 @@ struct event_eth_rx_adapter_test_params {
>                         .mq_mode = ETH_MQ_RX_RSS,

Ideally you need to set .mq_mode as ETH_MQ_RX_NONE to disable RSS.

>                         .max_rx_pkt_len = ETHER_MAX_LEN
>                 },
> -               .rx_adv_conf = {
> -                       .rss_conf = {
> -                               .rss_hf = ETH_RSS_IP |
> -                                       ETH_RSS_TCP |
> -                                       ETH_RSS_UDP,
> -                       }
> -               }
>         };
> 
>         return port_init_common(port, &port_conf_default, mp);
> --
> 1.8.3.1
>