From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 2/2] test/eventdev: remove eth Rx adapter
	vdev workaround
Date: Thu, 20 Sep 2018 06:38:43 +0000
Message-ID: <20180920063835.GB2283@jerin>
References: <1536225103-181590-1-git-send-email-nikhil.rao@intel.com>
 <1536225103-181590-2-git-send-email-nikhil.rao@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "vipin.varghese@intel.com"
 <vipin.varghese@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
To: Nikhil Rao <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1536225103-181590-2-git-send-email-nikhil.rao@intel.com>
Content-Language: en-US
Content-ID: <10EDC93FAC79044EB5CC817A90D2C217@namprd07.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Thu, 6 Sep 2018 14:41:43 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
>  vipin.varghese@intel.com, stable@dpdk.org
> Subject: [PATCH 2/2] test/eventdev: remove eth Rx adapter vdev workaround
> X-Mailer: git-send-email 1.8.3.1
>=20
>=20
> eth Rx adapter has been updated to support hotplugged
> devices, devices created after adapter creation can now be
> added to the adapter.
>=20
> Update the adapter_multi_eth_add_del
> test case to create the adapter as part of test setup
> instead of creating it after creating vdevs.
>=20
> Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
> Cc: vipin.varghese@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>


Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  test/test/test_event_eth_rx_adapter.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>=20
> diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event=
_eth_rx_adapter.c
> index 4cca77f..d6d137e 100644
> --- a/test/test/test_event_eth_rx_adapter.c
> +++ b/test/test/test_event_eth_rx_adapter.c
> @@ -489,9 +489,6 @@ struct event_eth_rx_adapter_test_params {
>         err =3D init_ports(rte_eth_dev_count_total());
>         TEST_ASSERT(err =3D=3D 0, "Port initialization failed err %d\n", =
err);
>=20
> -       /* creating new instance for all newly added eth devices */
> -       adapter_create();
> -
>         /* eth_rx_adapter_queue_add for n ports */
>         port_index =3D 0;
>         for (; port_index < rte_eth_dev_count_total(); port_index +=3D 1)=
 {
> @@ -509,8 +506,6 @@ struct event_eth_rx_adapter_test_params {
>                 TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err);
>         }
>=20
> -       adapter_free();
> -
>         return TEST_SUCCESS;
>  }
>=20
> @@ -675,7 +670,8 @@ struct event_eth_rx_adapter_test_params {
>                 TEST_CASE_ST(NULL, NULL, adapter_create_free),
>                 TEST_CASE_ST(adapter_create, adapter_free,
>                                         adapter_queue_add_del),
> -               TEST_CASE_ST(NULL, NULL, adapter_multi_eth_add_del),
> +               TEST_CASE_ST(adapter_create, adapter_free,
> +                                       adapter_multi_eth_add_del),
>                 TEST_CASE_ST(adapter_create, adapter_free, adapter_start_=
stop),
>                 TEST_CASE_ST(adapter_create, adapter_free, adapter_stats)=
,
>                 TEST_CASES_END() /**< NULL terminate unit test array */
> --
> 1.8.3.1
>=20