From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] test/eventdev: fix incorrect unit test
Date: Sun, 23 Sep 2018 14:29:07 +0530
Message-ID: <20180923085905.GA30840@jerin>
References: <20180905142331.9167-1-pbhagavatula@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0060.outbound.protection.outlook.com [104.47.32.60])
 by dpdk.org (Postfix) with ESMTP id C4F60201
 for <dev@dpdk.org>; Sun, 23 Sep 2018 10:59:29 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180905142331.9167-1-pbhagavatula@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Wed,  5 Sep 2018 19:53:31 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] test/eventdev: fix incorrect unit test
> X-Mailer: git-send-email 2.18.0
> 
> Enqueue, dequeue depths are only valid for event devs that have burst
> mode capability. Check event dev capability before testing depth
> boundary.
> 
> Fixes: f8f9d233ea0e ("test/eventdev: add unit tests")

Cc: stable@dpdk.org

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>  test/test/test_eventdev.c | 21 ++++++++++++---------
>  1 file changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c
> index 04bdc6b6c..00d73275c 100644
> --- a/test/test/test_eventdev.c
> +++ b/test/test/test_eventdev.c
> @@ -190,15 +190,18 @@ test_eventdev_configure(void)
>  		 "Config negative test failed");
>  	TEST_ASSERT_EQUAL(-EINVAL,
>  		test_ethdev_config_run(&dev_conf, &info, max_event_queue_flows),
> -		 "Config negative test failed");
> -	TEST_ASSERT_EQUAL(-EINVAL,
> -		test_ethdev_config_run(&dev_conf, &info,
> -			max_event_port_dequeue_depth),
> -			 "Config negative test failed");
> -	TEST_ASSERT_EQUAL(-EINVAL,
> -		test_ethdev_config_run(&dev_conf, &info,
> -		max_event_port_enqueue_depth),
> -		 "Config negative test failed");
> +		"Config negative test failed");
> +
> +	if (info.event_dev_cap & RTE_EVENT_DEV_CAP_BURST_MODE) {
> +		TEST_ASSERT_EQUAL(-EINVAL,
> +				test_ethdev_config_run(&dev_conf, &info,
> +					max_event_port_dequeue_depth),
> +				"Config negative test failed");
> +		TEST_ASSERT_EQUAL(-EINVAL,
> +				test_ethdev_config_run(&dev_conf, &info,
> +					max_event_port_enqueue_depth),
> +				"Config negative test failed");
> +	}
>  
>  	/* Positive case */
>  	devconf_set_default_sane_values(&dev_conf, &info);
> -- 
> 2.18.0
>