From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] event/sw: fix cq idx check for unlink
	usecases
Date: Sun, 23 Sep 2018 16:57:28 +0530
Message-ID: <20180923112727.GE20954@jerin>
References: <20180921102510.24179-1-harry.van.haaren@intel.com>
 <F3CD651E-19C9-4ED2-8561-6FE73E9A64F2@nokia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Harry van Haaren <harry.van.haaren@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
To: "Elo, Matias (Nokia - FI/Espoo)" <matias.elo@nokia.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <F3CD651E-19C9-4ED2-8561-6FE73E9A64F2@nokia.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 21 Sep 2018 12:17:38 +0000
> From: "Elo, Matias (Nokia - FI/Espoo)" <matias.elo@nokia.com>
> To: Harry van Haaren <harry.van.haaren@intel.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH] event/sw: fix cq idx check for unlink
>  usecases
> x-mailer: Apple Mail (2.3445.9.1)
> 
> 
> > On 21 Sep 2018, at 13:25, Harry van Haaren <harry.van.haaren@intel.com> wrote:
> >
> > This commit fixes the cq index checks when unlinking
> > ports/queues while the scheduler core is running.
> > Previously, the == comparison could be "skipped" if
> > in particular corner cases. With the check being changed
> > to >= this is resolved as the cq idx gets reset to zero.
> >
> > Bugzilla ID: 60
> > Fixes: 617995dfc5b2 ("event/sw: add scheduling logic")
> >
> > Suggested-by: Matias Elo <matias.elo@nokia.com>
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> >
> > ---
> >
> > Cc: stable@dpdk.org
> >
> > @Matias,
> >
> > When testing this patch with your provided test case as per attachment
> > to bug #60 in Bugzilla, I don't see any events arriving to port 0.
> > Hence, I believe this to be the correct behaviour, if you can confirm
> > that'd be awesome!
> >
> 
> I can confirm that this patch fixes the problem also on my system. Thanks!
> 
> I can’t remember if I ever saw this problem with ordered queues. At least now they seem to be also working correctly.
> 
> Regards,
> Matias

Cc: stable@dpdk.org

Applied to dpdk-next-eventdev/master. Thanks.

>