From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2] examples/client_server_mp: add sigint handler to server Date: Thu, 27 Sep 2018 15:37:02 +0100 Message-ID: <20180927143702.GA2380@bricha3-MOBL.ger.corp.intel.com> References: <1538047613-27309-1-git-send-email-rasland@mellanox.com> <9568922.17cOiG4SW6@xps> <20180927123053.GB776@bricha3-MOBL.ger.corp.intel.com> <5489324.HoVYYzflKP@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Raslan Darawsheh , dev@dpdk.org, shahafs@mellanox.com, orika@mellanox.com To: Thomas Monjalon Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 10D6B1B48D for ; Thu, 27 Sep 2018 16:40:36 +0200 (CEST) Content-Disposition: inline In-Reply-To: <5489324.HoVYYzflKP@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 27, 2018 at 02:48:38PM +0200, Thomas Monjalon wrote: > 27/09/2018 14:30, Bruce Richardson: > > On Thu, Sep 27, 2018 at 01:36:06PM +0200, Thomas Monjalon wrote: > > > 27/09/2018 13:26, Raslan Darawsheh: > > > > v2: > > > > - fix includes order > > > > > > I'm afraid you will need a v3 to fix spacing :) > > > > > > > --- a/examples/multi_process/client_server_mp/mp_server/main.c > > > > +++ b/examples/multi_process/client_server_mp/mp_server/main.c > > > > @@ -37,6 +37,7 @@ > > > > #include "common.h" > > > > #include "args.h" > > > > #include "init.h" > > > > +#include > > > > > > A space is missing here. > > > > > > > Also, the norm in DPDK is to list all standard headers first, then the DPDK > > headers and finally the local headers. "signal.h" therefore should be > > further up in the file, with the first group. > > I think he did that already in v3 :) > Yes, he did. I just need the ability to read all mails in parallel, while also typing up new ones. :-)