From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH v2 2/2] event/dpaa: add select based event support Date: Fri, 28 Sep 2018 17:13:15 +0530 Message-ID: <20180928114314.GA22543@jerin> References: <1535607196-26782-1-git-send-email-hemant.agrawal@nxp.com> <1537858955-6884-1-git-send-email-hemant.agrawal@nxp.com> <1537858955-6884-2-git-send-email-hemant.agrawal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Hemant Agrawal Return-path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0065.outbound.protection.outlook.com [104.47.38.65]) by dpdk.org (Postfix) with ESMTP id 4A54F1B396 for ; Fri, 28 Sep 2018 13:44:57 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1537858955-6884-2-git-send-email-hemant.agrawal@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Tue, 25 Sep 2018 12:32:35 +0530 > From: Hemant Agrawal > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.com > Subject: [PATCH v2 2/2] event/dpaa: add select based event support > X-Mailer: git-send-email 2.7.4 > > > This patch add support to use select call with qman portal fd > for timeout based dequeue request for eventdev. > > If there is a event available qman portal fd will be set > and the function will be awakened. If no event is available, > it will only wait till the given timeout value. > > In case of interrupt the timeout ticks are used as usecs. > > Signed-off-by: Hemant Agrawal > --- > Note: This patch has a dependency on following patch series: > http://mails.dpdk.org/archives/dev/2018-September/112433.html > which is now part of dpdk-next-net tree. I will pull this patch when the depended patch show up on master branch. Currently it has following build errors, I assume it is due to dependency patch. /export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c: In function ‘drain_4_bytes’: /export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c:121:24: error: implicit declaration of function ‘qman_thread_fd’; did you mean ‘qman_thread_irq’? [-Werror=implicit-function-declaration] ssize_t sjunk = read(qman_thread_fd(), &junk, sizeof(junk)); ^~~~~~~~~~~~~~ qman_thread_irq /export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c:121:24: error: nested extern declaration of ‘qman_thread_fd’ [-Werror=nested-externs] /export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c: In function ‘dpaa_event_dequeue_wait’: /export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c:148:2: error: implicit declaration of function ‘qman_irqsource_add’; did you mean ‘qman_reserve_fqid’? [-Werror=implicit-function-declaration] qman_irqsource_add(QM_PIRQ_DQRI); ^~~~~~~~~~~~~~~~~~ qman_reserve_fqid /export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c:148:2: error: nested extern declaration of ‘qman_irqsource_add’ [-Werror=nested-externs] /export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c:159:2: error: implicit declaration of function ‘qman_irqsource_remove’; did you mean ‘qman_reserve_pool’? [-Werror=implicit-function-declaration] qman_irqsource_remove(~0); ^~~~~~~~~~~~~~~~~~~~~ qman_reserve_pool /export/dpdk-next-eventdev/drivers/event/dpaa/dpaa_eventdev.c:159:2: error: nested extern declaration of ‘qman_irqsource_remove’ [-Werror=nested-externs] >