From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: [PATCH 1/2] drivers/net: remove double assignment of driver Date: Fri, 28 Sep 2018 17:56:03 +0530 Message-ID: <20180928122604.32618-1-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain Cc: dev@dpdk.org, hemant.agrawal@nxp.com, Shreyansh Jain To: thomas@monjalon.net Return-path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10048.outbound.protection.outlook.com [40.107.1.48]) by dpdk.org (Postfix) with ESMTP id CC3961B3D2 for ; Fri, 28 Sep 2018 14:26:48 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Removing double copy of driver information. 04664e5c8346 has shifted that from driver's probe to bus's probe. Fixes: 04664e5c8346 ("drivers/bus: fill driver reference after NXP probing") Cc: thomas@monjalon.net Signed-off-by: Shreyansh Jain --- drivers/net/dpaa/dpaa_ethdev.c | 3 +-- drivers/net/dpaa2/dpaa2_ethdev.c | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 30eff657a..de4cf7b37 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -1371,7 +1371,7 @@ dpaa_dev_uninit(struct rte_eth_dev *dev) } static int -rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv, +rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused, struct rte_dpaa_device *dpaa_dev) { int diag; @@ -1455,7 +1455,6 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv, } eth_dev->device = &dpaa_dev->device; - eth_dev->device->driver = &dpaa_drv->driver; dpaa_dev->eth_dev = eth_dev; /* Invoke PMD device initialization function */ diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 8d3d54bfe..880034fcf 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -2007,7 +2007,6 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv, } eth_dev->device = &dpaa2_dev->device; - eth_dev->device->driver = &dpaa2_drv->driver; dpaa2_dev->eth_dev = eth_dev; eth_dev->data->rx_mbuf_alloc_failed = 0; -- 2.17.1