From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yongseok Koh Subject: Re: [PATCH] net/mlx5: allow flow rule with attribute egress Date: Wed, 3 Oct 2018 07:28:16 +0000 Message-ID: <20181003072804.GB21743@mtidpdk.mti.labs.mlnx> References: <1538058330-34990-1-git-send-email-dekelp@mellanox.com> <20180929092415.GB95127@minint-98vp2qg> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Shahaf Shuler , Ori Kam To: Dekel Peled Return-path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0084.outbound.protection.outlook.com [104.47.2.84]) by dpdk.org (Postfix) with ESMTP id 4B478200 for ; Wed, 3 Oct 2018 09:28:20 +0200 (CEST) In-Reply-To: Content-Language: en-US Content-ID: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 02, 2018 at 11:06:07PM -0700, Dekel Peled wrote: > Thanks, PSB. >=20 > > -----Original Message----- > > From: Yongseok Koh > > Sent: Saturday, September 29, 2018 12:24 PM > > To: Dekel Peled > > Cc: dev@dpdk.org; Shahaf Shuler ; Ori Kam > > > > Subject: Re: [PATCH] net/mlx5: allow flow rule with attribute egress > >=20 > > On Thu, Sep 27, 2018 at 05:25:30PM +0300, Dekel Peled wrote: > > > This patch complements [1], adding to MLX5 PMD the option to set flow > > > rule for egress traffic. > > > > > > [1] "net/mlx5: support metadata as flow rule criteria" > > > http://mails.dpdk.org/archives/dev/2018-September/113275.html > > > > > > Signed-off-by: Dekel Peled > > > --- > > > drivers/net/mlx5/mlx5_flow.c | 54 > > ++++++++++++++++++++++++++++++++++++++ > > > drivers/net/mlx5/mlx5_flow.h | 6 +++++ > > > drivers/net/mlx5/mlx5_flow_dv.c | 24 ++++++++++------- > > > drivers/net/mlx5/mlx5_flow_verbs.c | 7 ++++- > > > 4 files changed, 80 insertions(+), 11 deletions(-) > > > > > > diff --git a/drivers/net/mlx5/mlx5_flow.c > > > b/drivers/net/mlx5/mlx5_flow.c index 9581691..79a06df 100644 > > > --- a/drivers/net/mlx5/mlx5_flow.c > > > +++ b/drivers/net/mlx5/mlx5_flow.c > > > @@ -644,6 +644,8 @@ uint32_t mlx5_flow_adjust_priority(struct > > rte_eth_dev *dev, int32_t priority, > > > * > > > * @param[in] action_flags > > > * Bit-fields that holds the actions detected until now. > > > + * @param[in] attr > > > + * Attributes of flow that includes this action. > > > * @param[out] error > > > * Pointer to error structure. > > > * > > > @@ -652,6 +654,7 @@ uint32_t mlx5_flow_adjust_priority(struct > > rte_eth_dev *dev, int32_t priority, > > > */ > > > int > > > mlx5_flow_validate_action_flag(uint64_t action_flags, > > > + const struct rte_flow_attr *attr, > > > struct rte_flow_error *error) { > > > > > > @@ -668,6 +671,12 @@ uint32_t mlx5_flow_adjust_priority(struct > > rte_eth_dev *dev, int32_t priority, > > > RTE_FLOW_ERROR_TYPE_ACTION, > > NULL, > > > "can't have 2 flag" > > > " actions in same flow"); > > > + if (attr->egress) > > > + return rte_flow_error_set(error, ENOTSUP, > > > + > > RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, > > > + NULL, > >=20 > > These two lines could be one line. > Can't do, It exceeds the 80 characters limit. if (attr->egress) return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, NULL, 012345678901234567890123456789012345678901234567890123456789012345678901234= 56789 "flag action not supported for " "egress"); Exactly 80 :-) Thanks, Yongseok