From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 2/4] hash: add extendable bucket feature
Date: Wed, 3 Oct 2018 08:08:46 -0700
Message-ID: <20181003080846.453881fa@xeon-e3>
References: <1537993618-92630-1-git-send-email-yipeng1.wang@intel.com>
 <1538155426-145177-1-git-send-email-yipeng1.wang@intel.com>
 <1538155426-145177-3-git-send-email-yipeng1.wang@intel.com>
 <AM6PR08MB3672608643961F72B966355098E80@AM6PR08MB3672.eurprd08.prod.outlook.com>
 <D2C4A16CA39F7F4E8E384D204491D7A6614EB03C@FMSMSX151.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "Richardson, Bruce"
 <bruce.richardson@intel.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Gobriel,
 Sameh" <sameh.gobriel@intel.com>, nd <nd@arm.com>
To: "Wang, Yipeng1" <yipeng1.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com
 [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id DED9D4CA5
 for <dev@dpdk.org>; Wed,  3 Oct 2018 17:08:49 +0200 (CEST)
Received: by mail-pf1-f194.google.com with SMTP id c25-v6so1517311pfe.6
 for <dev@dpdk.org>; Wed, 03 Oct 2018 08:08:49 -0700 (PDT)
In-Reply-To: <D2C4A16CA39F7F4E8E384D204491D7A6614EB03C@FMSMSX151.amr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 2 Oct 2018 23:39:51 +0000
"Wang, Yipeng1" <yipeng1.wang@intel.com> wrote:

> >> +		if (last_bkt->key_idx[i] != EMPTY_SLOT) {
> >> +			cur_bkt->key_idx[pos] = last_bkt->key_idx[i];
> >> +			cur_bkt->sig_current[pos] = last_bkt->sig_current[i];
> >> +			cur_bkt->sig_alt[pos] = last_bkt->sig_alt[i];
> >> +			last_bkt->sig_current[i] = NULL_SIGNATURE;
> >> +			last_bkt->sig_alt[i] = NULL_SIGNATURE;
> >> +			last_bkt->key_idx[i] = EMPTY_SLOT;
> >> +			return;  
> >In lock-free algorithm, this will require the global counter increment.
> >  
> [Wang, Yipeng] I agree. Similar to your protect for cuckoo displacement, protecting the copy part