From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition Date: Wed, 3 Oct 2018 16:45:51 +0530 Message-ID: <20181003111550.GA9248@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-1-jerin.jacob@caviumnetworks.com> <2601191342CEEE43887BDE71AB9772580102FE1479@IRSMSX106.ger.corp.intel.com> <20181003085909.GA9894@jerin> <2601191342CEEE43887BDE71AB9772580102FE152A@IRSMSX106.ger.corp.intel.com> <20181003092159.GB9894@jerin> <2601191342CEEE43887BDE71AB9772580102FE159A@IRSMSX106.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , "Mcnamara, John" , "Kovacevic, Marko" , Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , Olivier Matz , "dev@dpdk.org" , "shahafs@mellanox.com" To: "Ananyev, Konstantin" Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0061.outbound.protection.outlook.com [104.47.36.61]) by dpdk.org (Postfix) with ESMTP id 999F31B10A for ; Wed, 3 Oct 2018 13:16:15 +0200 (CEST) Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB9772580102FE159A@IRSMSX106.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Wed, 3 Oct 2018 10:16:31 +0000 > From: "Ananyev, Konstantin" > To: Jerin Jacob > CC: "Lu, Wenzhuo" , "Wu, Jingjing" > , "Iremonger, Bernard" > , "Mcnamara, John" , > "Kovacevic, Marko" , Thomas Monjalon > , "Yigit, Ferruh" , Andrew > Rybchenko , Olivier Matz > , "dev@dpdk.org" , > "shahafs@mellanox.com" > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > checksum definition > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Wednesday, October 3, 2018 10:22 AM > > To: Ananyev, Konstantin > > Cc: Lu, Wenzhuo ; Wu, Jingjing ; Iremonger, Bernard ; > > Mcnamara, John ; Kovacevic, Marko ; Thomas Monjalon > > ; Yigit, Ferruh ; Andrew Rybchenko ; Olivier Matz > > ; dev@dpdk.org; shahafs@mellanox.com > > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition > > > > -----Original Message----- > > > Date: Wed, 3 Oct 2018 09:17:18 +0000 > > > From: "Ananyev, Konstantin" > > > To: Jerin Jacob > > > CC: "Lu, Wenzhuo" , "Wu, Jingjing" > > > , "Iremonger, Bernard" > > > , "Mcnamara, John" , > > > "Kovacevic, Marko" , Thomas Monjalon > > > , "Yigit, Ferruh" , Andrew > > > Rybchenko , Olivier Matz > > > , "dev@dpdk.org" , > > > "shahafs@mellanox.com" > > > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > > > checksum definition > > > > > > > > > > -----Original Message----- > > > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > > > Sent: Wednesday, October 3, 2018 9:59 AM > > > > To: Ananyev, Konstantin > > > > Cc: Lu, Wenzhuo ; Wu, Jingjing ; Iremonger, Bernard > > ; > > > > Mcnamara, John ; Kovacevic, Marko ; Thomas Monjalon > > > > ; Yigit, Ferruh ; Andrew Rybchenko ; Olivier Matz > > > > ; dev@dpdk.org; shahafs@mellanox.com > > > > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition > > > > > > > > -----Original Message----- > > > > > Date: Wed, 3 Oct 2018 08:53:22 +0000 > > > > > From: "Ananyev, Konstantin" > > > > > To: Jerin Jacob , "Lu, Wenzhuo" > > > > > , "Wu, Jingjing" , > > > > > "Iremonger, Bernard" , "Mcnamara, John" > > > > > , "Kovacevic, Marko" , > > > > > Thomas Monjalon , "Yigit, Ferruh" > > > > > , Andrew Rybchenko , > > > > > Olivier Matz > > > > > CC: "dev@dpdk.org" , "shahafs@mellanox.com" > > > > > > > > > > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > > > > > checksum definition > > > > > > > > > > > > > > > Hi Jerin, > > > > > > > > Hi Konstantin, > > > > > > > > > > > > > > > > > > > > > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and > > > > > > PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to detect outer UDP checksum > > > > > > failure. > > > > > > > > > > > > - To use hardware Rx outer UDP checksum offload, the user needs to > > > > > > configure DEV_RX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slowpath. > > > > > > > > > > > > - Driver updates the PKT_RX_EL4_CKSUM_BAD mbuf ol_flag on checksum failure > > > > > > similar to the outer L3 PKT_RX_EIP_CKSUM_BAD flag. > > > > > > > > > > > > Signed-off-by: Jerin Jacob > > > > > > > > > > Looks ok to me in general. > > > > > Just wonder is there any PMD that supports all these new features? > > > > > > > > octeontx2 PMD has this feature. I am planning to push the PMD for v19.02. > > > > Before that I adding all the common code change to avoid the dependency. > > > > > > Ok, but why then ethdev/mbuf changes has to go into 18.11? > > > > It it is a generic change then why not? What is the real concern here? > > If there is no implementation for it, how we can conclude that it is really 'generic' one? :) > My main concern is that we already have several features in rte_ethdev and rte_security > that supposed to be 'generic' but right now no-one support them. I think, this case is pretty straight forward changes. > I wouldn't to object about these particular features, they look reasonable to me. OK. > But in general I think we need some better defined policy - > about what is allowed to propagate without real evidence (particular implementation) > and what is not. I am open for the policy definition. > > > > > > Do you plan your new PMD backward compatible with 18.11 LTS? > > > > Yes. > > I see. > Konstantin >