From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yongseok Koh Subject: Re: [PATCH 2/3] app/testpmd: add commands of modify MAC address Date: Wed, 3 Oct 2018 20:09:13 +0000 Message-ID: <20181003200903.GE26206@mtidpdk.mti.labs.mlnx> References: <20180925150340.25378-1-jackmin@mellanox.com> <20180925150340.25378-3-jackmin@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "ferruh.yigit@intel.com" , Adrien Mazarguil , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , "dev@dpdk.org" To: Jack Min Return-path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60056.outbound.protection.outlook.com [40.107.6.56]) by dpdk.org (Postfix) with ESMTP id 1032C1B2AE for ; Wed, 3 Oct 2018 22:09:15 +0200 (CEST) In-Reply-To: <20180925150340.25378-3-jackmin@mellanox.com> Content-Language: en-US Content-ID: <7B3F4C33A0081E44A03CD7273AFC05A6@eurprd05.prod.outlook.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 25, 2018 at 11:03:39PM +0800, Xiaoyu Min wrote: > add commands to support following actions: >=20 > - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC > - RTE_FLOW_ACTION_TYPE_SET_MAC_DST >=20 > Signed-off-by: Xiaoyu Min > --- Acked-by: Yongseok Koh Thanks > app/test-pmd/cmdline_flow.c | 50 +++++++++++++++++++++ > app/test-pmd/config.c | 4 ++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++++ > 3 files changed, 62 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index fae825462..d06e75799 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -258,6 +258,10 @@ enum index { > ACTION_DEC_TTL, > ACTION_SET_TTL, > ACTION_SET_TTL_TTL, > + ACTION_SET_MAC_SRC, > + ACTION_SET_MAC_SRC_MAC_SRC, > + ACTION_SET_MAC_DST, > + ACTION_SET_MAC_DST_MAC_DST, > }; > =20 > /** Maximum size for pattern in struct rte_flow_item_raw. */ > @@ -839,6 +843,8 @@ static const enum index next_action[] =3D { > ACTION_SET_TP_DST, > ACTION_DEC_TTL, > ACTION_SET_TTL, > + ACTION_SET_MAC_SRC, > + ACTION_SET_MAC_DST, > ZERO, > }; > =20 > @@ -947,6 +953,12 @@ static const enum index action_set_ipv4_src[] =3D { > ZERO, > }; > =20 > +static const enum index action_set_mac_src[] =3D { > + ACTION_SET_MAC_SRC_MAC_SRC, > + ACTION_NEXT, > + ZERO, > +}; > + > static const enum index action_set_ipv4_dst[] =3D { > ACTION_SET_IPV4_DST_IPV4_DST, > ACTION_NEXT, > @@ -989,6 +1001,12 @@ static const enum index action_jump[] =3D { > ZERO, > }; > =20 > +static const enum index action_set_mac_dst[] =3D { > + ACTION_SET_MAC_DST_MAC_DST, > + ACTION_NEXT, > + ZERO, > +}; > + > static int parse_init(struct context *, const struct token *, > const char *, unsigned int, > void *, unsigned int); > @@ -2654,6 +2672,38 @@ static const struct token token_list[] =3D { > (struct rte_flow_action_set_ttl, ttl_value)), > .call =3D parse_vc_conf, > }, > + [ACTION_SET_MAC_SRC] =3D { > + .name =3D "set_mac_src", > + .help =3D "set source mac address", > + .priv =3D PRIV_ACTION(SET_MAC_SRC, > + sizeof(struct rte_flow_action_set_mac)), > + .next =3D NEXT(action_set_mac_src), > + .call =3D parse_vc, > + }, > + [ACTION_SET_MAC_SRC_MAC_SRC] =3D { > + .name =3D "mac_addr", > + .help =3D "new source mac address", > + .next =3D NEXT(action_set_mac_src, NEXT_ENTRY(MAC_ADDR)), > + .args =3D ARGS(ARGS_ENTRY_HTON > + (struct rte_flow_action_set_mac, mac_addr)), > + .call =3D parse_vc_conf, > + }, > + [ACTION_SET_MAC_DST] =3D { > + .name =3D "set_mac_dst", > + .help =3D "set destination mac address", > + .priv =3D PRIV_ACTION(SET_MAC_DST, > + sizeof(struct rte_flow_action_set_mac)), > + .next =3D NEXT(action_set_mac_dst), > + .call =3D parse_vc, > + }, > + [ACTION_SET_MAC_DST_MAC_DST] =3D { > + .name =3D "mac_addr", > + .help =3D "new destination mac address to set", > + .next =3D NEXT(action_set_mac_dst, NEXT_ENTRY(MAC_ADDR)), > + .args =3D ARGS(ARGS_ENTRY_HTON > + (struct rte_flow_action_set_mac, mac_addr)), > + .call =3D parse_vc_conf, > + }, > }; > =20 > /** Remove and return last entry from argument stack. */ > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index d28b6ed14..c2cbf5ce8 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1177,6 +1177,10 @@ static const struct { > MK_FLOW_ACTION(DEC_TTL, 0), > MK_FLOW_ACTION(SET_TTL, > sizeof(struct rte_flow_action_set_ttl)), > + MK_FLOW_ACTION(SET_MAC_SRC, > + sizeof(struct rte_flow_action_set_mac)), > + MK_FLOW_ACTION(SET_MAC_DST, > + sizeof(struct rte_flow_action_set_mac)), > }; > =20 > /** Compute storage space needed by action configuration and copy it. */ > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/tes= tpmd_app_ug/testpmd_funcs.rst > index db68c4346..0a8cc73a3 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -3726,6 +3726,14 @@ This section lists supported actions and their att= ributes, if any. > - ``set_ttl``: Set TTL value with specificed value > - ``ttl_value {unsigned}``: The new TTL value to be set > =20 > +- ``set_mac_src``: set source MAC address > + > + - ``mac_addr {MAC-48}``: new source MAC address > + > +- ``set_mac_dst``: set destination MAC address > + > + - ``mac_addr {MAC-48}``: new destination MAC address > + > Destroying flow rules > ~~~~~~~~~~~~~~~~~~~~~ > =20 > --=20 > 2.17.1 >=20