From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
Date: Sat, 6 Oct 2018 13:35:26 +0530
Message-ID: <20181006080524.GA21149@jerin>
References: <20181005044606.27026-1-jerin.jacob@caviumnetworks.com>
 <d3d809fa-2f29-74bc-fbb7-9f0bfbe9bfb3@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org,
 thomas@monjalon.net, arybchenko@solarflare.com,
 olivier.matz@6wind.com, stable@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <d3d809fa-2f29-74bc-fbb7-9f0bfbe9bfb3@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 5 Oct 2018 20:56:47 +0100
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, John McNamara
>  <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>
> CC: dev@dpdk.org, thomas@monjalon.net, arybchenko@solarflare.com,
>  olivier.matz@6wind.com, stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
>  Thunderbird/52.9.1
> 
> External Email
> 
> On 10/5/2018 5:46 AM, Jerin Jacob wrote:
> > Based on PKT_TX_IP_CKSUM definition the user needs
> > to fill l2_len and l3_len mbuf fields before issuing
> > HW Tx checksum request.
> >
> > Fixes: dad1ec72a377 ("doc: document NIC features")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >
> > See PKT_TX_IP_CKSUM at
> > https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n283
> >
> > ---
> >  doc/guides/nics/features.rst | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> > index b085bda86..e726a6bb8 100644
> > --- a/doc/guides/nics/features.rst
> > +++ b/doc/guides/nics/features.rst
> > @@ -562,6 +562,7 @@ Supports L3 checksum offload.
> >  * **[uses]     rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_IPV4_CKSUM``.
> >  * **[uses]     mbuf**: ``mbuf.ol_flags:PKT_TX_IP_CKSUM``,
> >    ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``.
> > +* **[uses]     mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``.
> 
> Thanks this was missing.
> 
> ``mbuf.l2_len``, ``mbuf.l3_len`` are required for TX CKSUM offload, in
> documentation there is no distinction for Rx or Tx, do you think does it worth
> to clarify PMD `uses` these values for Tx cksum offload only?

IMO, there will not be any confusion as mbuf.l2_len comes under
uint64_t tx_offload in struct rte_mbuf.



> 
> 
> >  * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_IP_CKSUM_UNKNOWN`` |
> >    ``PKT_RX_IP_CKSUM_BAD`` | ``PKT_RX_IP_CKSUM_GOOD`` |
> >    ``PKT_RX_IP_CKSUM_NONE``.
> >
>