From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] drivers/net: fix log type string
Date: Tue, 9 Oct 2018 08:07:11 -0700
Message-ID: <20181009080711.07236f72@xeon-e3>
References: <20181009115238.91288-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur
 <somnath.kotur@broadcom.com>, Declan Doherty <declan.doherty@intel.com>,
 Chas Williams <chas3@att.com>, Matan Azrad <matan@mellanox.com>,
 dev@dpdk.org, stable@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com
 [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id AFD141B57F
 for <dev@dpdk.org>; Tue,  9 Oct 2018 17:07:20 +0200 (CEST)
Received: by mail-pg1-f196.google.com with SMTP id g2-v6so944729pgu.11
 for <dev@dpdk.org>; Tue, 09 Oct 2018 08:07:20 -0700 (PDT)
In-Reply-To: <20181009115238.91288-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue,  9 Oct 2018 12:52:38 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> Syntax for log type string is "pmd.<subsystem>.<driver>[.<pmd_local>]"
> 
> Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type")
> Fixes: d7f4562ab10a ("net/bonding: convert to dynamic logging")
> Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  drivers/net/bnxt/bnxt_ethdev.c         | 2 +-
>  drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
>  drivers/net/vdev_netvsc/vdev_netvsc.c  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 88e026c7d..858e65d00 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -3569,7 +3569,7 @@ bool is_bnxt_supported(struct rte_eth_dev *dev)
>  
>  RTE_INIT(bnxt_init_log)
>  {
> -	bnxt_logtype_driver = rte_log_register("pmd.bnxt.driver");
> +	bnxt_logtype_driver = rte_log_register("pmd.net.bnxt.driver");
>  	if (bnxt_logtype_driver >= 0)
>  		rte_log_set_level(bnxt_logtype_driver, RTE_LOG_INFO);
>  }
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index a7b592eed..544e0cde4 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -3598,7 +3598,7 @@ int bond_logtype;
>  
>  RTE_INIT(bond_init_log)
>  {
> -	bond_logtype = rte_log_register("pmd.net.bon");
> +	bond_logtype = rte_log_register("pmd.net.bond");
>  	if (bond_logtype >= 0)
>  		rte_log_set_level(bond_logtype, RTE_LOG_NOTICE);
>  }
> diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c
> index 48717f2f0..16303ef5e 100644
> --- a/drivers/net/vdev_netvsc/vdev_netvsc.c
> +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c
> @@ -789,7 +789,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_vdev_netvsc,
>  /** Initialize driver log type. */
>  RTE_INIT(vdev_netvsc_init_log)
>  {
> -	vdev_netvsc_logtype = rte_log_register("pmd.vdev_netvsc");
> +	vdev_netvsc_logtype = rte_log_register("pmd.net.vdev_netvsc");
>  	if (vdev_netvsc_logtype >= 0)
>  		rte_log_set_level(vdev_netvsc_logtype, RTE_LOG_NOTICE);
>  }

Thanks for making drivers consistent.
Did you check the documentation?

Acked-by: Stephen Hemminger <stephen@networkplumber.org>