From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH v6 2/2] net/virtio: fix PCI config err
	handling
Date: Thu, 11 Oct 2018 21:01:01 +0800
Message-ID: <20181011130100.GA628@debian>
References: <20180827165240.28322-1-bluca@debian.org>
 <20180828101240.12597-1-bluca@debian.org>
 <20180828101240.12597-2-bluca@debian.org> <2276842.FSxJgd8eX6@xps>
 <1539255192.8721.31.camel@debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org,
 maxime.coquelin@redhat.com, zhihong.wang@intel.com,
 bruce.richardson@intel.com, brian.russell@intl.att.com
To: Luca Boccassi <bluca@debian.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 8727C1B195
 for <dev@dpdk.org>; Thu, 11 Oct 2018 15:02:19 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1539255192.8721.31.camel@debian.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Oct 11, 2018 at 11:53:12AM +0100, Luca Boccassi wrote:
> On Thu, 2018-10-11 at 12:27 +0200, Thomas Monjalon wrote:
> > 28/08/2018 12:12, Luca Boccassi:
> > > From: Brian Russell <brussell@brocade.com>
> > > 
> > > In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config
> > > returns
> > > the number of bytes read from PCI config or < 0 on error.
> > > If less than the expected number of bytes are read then log the
> > > failure and return rather than carrying on with garbage.
> > > 
> > > Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0")
> > > 
> > > Signed-off-by: Brian Russell <brussell@brocade.com>
> > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > ---
> > > v2: handle additional rte_pci_read_config incomplete reads
> > > v3: do not handle rte_pci_read_config of virtio cap, added in v2,
> > >     as it's less clear what the right thing to do there is
> > > v4: do a more robust check - first check what the vendor is, and
> > >     skip the cap entirely if it's not what we are looking for.
> > > v5: fetch only 2 flags bytes if the vndr is PCI_CAP_ID_MSIX
> > > v6: fix 32bit build by changing the printf format specifier, fix
> > > patch title
> > 
> > Tiwei did a comment on v5 and provided his Reviewed-by.
> > Is it OK to apply v6 with its tag?
> > All is fixed?
> 
> Hi,
> 
> The title has been fixed (virtio -> net/virtio) and I just tried a
> 32bit build and it works fine after the fix from v6.

Thanks Luca!

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

> 
> -- 
> Kind regards,
> Luca Boccassi