From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re:
 =?utf-8?b?562U5aSNOiAgW1BBVENIXSBlYWwvcHBjNjQ6IGFkZCBz?=
 =?utf-8?q?upport_for_rte_pause?=
Date: Fri, 12 Oct 2018 09:42:57 +0530
Message-ID: <20181012041255.GA7250@jerin>
References: <20181007061857.29451-1-jerin.jacob@caviumnetworks.com>
 <000001d461d2$adc87910$09596b30$@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, thomas@monjalon.net, gowrishankar.m@linux.vnet.ibm.com,
 ola.liljedahl@arm.com
To: Chao Zhu <chaozhu@linux.vnet.ibm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0054.outbound.protection.outlook.com [104.47.36.54])
 by dpdk.org (Postfix) with ESMTP id C59BE1B0FC
 for <dev@dpdk.org>; Fri, 12 Oct 2018 06:13:25 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <000001d461d2$adc87910$09596b30$@linux.vnet.ibm.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 12 Oct 2018 10:24:16 +0800
> From: Chao Zhu <chaozhu@linux.vnet.ibm.com>
> To: 'Jerin Jacob' <jerin.jacob@caviumnetworks.com>
> CC: dev@dpdk.org, thomas@monjalon.net, gowrishankar.m@linux.vnet.ibm.com,
>  ola.liljedahl@arm.com
> Subject: 答复: [dpdk-dev] [PATCH] eal/ppc64: add support for rte pause
> X-Mailer: Microsoft Outlook 16.0
> 
> 
> -----邮件原件-----
> 发件人: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 发送时间: 2018年10月7日 14:19
> 收件人: Chao Zhu <chaozhu@linux.vnet.ibm.com>
> 抄送: dev@dpdk.org; thomas@monjalon.net; gowrishankar.m@linux.vnet.ibm.com;
> ola.liljedahl@arm.com; Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 主题: [dpdk-dev] [PATCH] eal/ppc64: add support for rte pause
> 
> Add support for rte_pause() implementation for ppc64.
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> 
> The reference implementation for Linux's cpu_relax() for ppc64 is at
> https://elixir.bootlin.com/linux/latest/source/arch/powerpc/include/asm/proc
> essor.h#L440
> 
> ---
>  lib/librte_eal/common/include/arch/ppc_64/rte_pause.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_pause.h
> b/lib/librte_eal/common/include/arch/ppc_64/rte_pause.h
> index 8bd835764..16e47ce22 100644
> --- a/lib/librte_eal/common/include/arch/ppc_64/rte_pause.h
> +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_pause.h
> @@ -9,10 +9,17 @@
>  extern "C" {
>  #endif
> 
> +#include "rte_atomic.h"
> +
>  #include "generic/rte_pause.h"
> 
>  static inline void rte_pause(void)
>  {
> +       /* Set hardware multi-threading low priority */
> +       asm volatile("or 1,1,1");
> +       /* Set hardware multi-threading medium priority */
> +       asm volatile("or 2,2,2");
> +       rte_compiler_barrier();
>  }
> 
>  #ifdef __cplusplus
> --
> 2.19.0
> 
> Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>

Thomas,

Just noticed, due to some reason, The above Acked-by: is not reflected in patchwork.

http://patches.dpdk.org/patch/46195/

Probably because, it was not a "inline" reply which patchwork couldn't parse it.


> 
>