From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2] build: add meson.build for kni kernel module Date: Fri, 12 Oct 2018 17:29:38 +0100 Message-ID: <20181012162938.GA11676@bricha3-MOBL.ger.corp.intel.com> References: <20181011194629.4699-1-bluca@debian.org> <20181012151221.11295-1-bluca@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, ferruh.yigit@intel.com To: Luca Boccassi Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C16361BACD for ; Fri, 12 Oct 2018 18:29:44 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20181012151221.11295-1-bluca@debian.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote: > A Kbuild is also included to allow users to use DKMS natively without > additional code. > > Signed-off-by: Luca Boccassi > --- > v2: add local directory to -I and build sources list recursively to > fix build on Fedora > Yep, now seems to build for me on Fedora. One minor suggestion is to look to use the "console" keyword on the custom_target if possible. It should help prevent noticable stalls as make runs in the background. [Unfortunately, it's meson 0.48 onward only, so if conditionals are needed, just ignore this suggestion] Also, do we want to use "make -j" for this, given the number of files? [Maybe -j4 just?] Tested-by: Bruce Richardson Acked-by: Bruce Richardson