From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huaibin Wang Subject: [PATCH] net/i40e: keep promisc on if allmulticast is enabled Date: Tue, 16 Oct 2018 05:27:37 +0200 Message-ID: <20181016032737.28869-1-huaibin.wang@6wind.com> Cc: Beilei Xing , Qi Zhang , huaibin Wang , Laurent Hardy To: dev@dpdk.org Return-path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 003D12C2F for ; Tue, 16 Oct 2018 05:28:00 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id r63-v6so20842728wma.4 for ; Mon, 15 Oct 2018 20:28:00 -0700 (PDT) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: huaibin Wang Promisc should not be disabled if the all multicast mode is enabled. Patch keeps the promiscuous on if all multicast mode is on, this behavior is also consistant with the implementation done on ixgbe pmd. Signed-off-by: huaibin Wang Signed-off-by: Laurent Hardy --- Cc: Beilei Xing Cc: Qi Zhang drivers/net/i40e/i40e_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index f7a685c8c..6c503debc 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2587,6 +2587,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev) if (status != I40E_SUCCESS) PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous"); + /* must remain in all_multicast mode */ + if (dev->data->all_multicast == 1) + return; + status = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid, false, NULL); if (status != I40E_SUCCESS) -- 2.11.0