From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Liang, Ma" <liang.j.ma@intel.com>
Subject: Re: [PATCH] devtools/check-symbol-changes.sh: awk script
	issue
Date: Fri, 19 Oct 2018 14:09:51 +0100
Message-ID: <20181019130951.GC1349@sivswdev01.ir.intel.com>
References: <1538666296-25742-1-git-send-email-liang.j.ma@intel.com>
 <5107033.R7BcetJnk1@xps>
 <20181019113815.GA30254@hmswarspite.think-freely.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
To: Neil Horman <nhorman@tuxdriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id EFC451B200
 for <dev@dpdk.org>; Fri, 19 Oct 2018 15:09:54 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20181019113815.GA30254@hmswarspite.think-freely.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Neil, 
   there are two things here. 
   1. This issue give me negative report when I run checkpatch.
      So, I hope we can disable symbol check before we fix it.

   2. How to fix that 
      I still don't understand why we need match section name start with '+'.
      The section name should start with 'A-Z' only for my opinion.

Regards
Liang

On 19 Oct 07:38, Neil Horman wrote:
> On Fri, Oct 19, 2018 at 12:48:57PM +0200, Thomas Monjalon wrote:
> > Hi Neil,
> > 
> > Are you OK with this patch?
> > 
> > 
> > 04/10/2018 17:18, Liang Ma:
> > > There is a issue inside check-symbol-changes.sh awk script.
> > > When the script try to parse the section name from  patch,
> > > The script put char "+" into the section name.
> > > 
> > > Signed-off-by: Liang Ma <liang.j.ma@intel.com>
> > > ---
> > >  devtools/check-symbol-change.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> > > index c0d2a6d..4a0f4d8 100755
> > > --- a/devtools/check-symbol-change.sh
> > > +++ b/devtools/check-symbol-change.sh
> > > @@ -30,7 +30,7 @@ build_map_changes()
> > >  		# the rest of the line with the + and { symbols remvoed.
> > >  		# Triggering this rule sets in_sec to 1, which actives the
> > >  		# symbol rule below
> > > -		/^.*{/ {
> > > +		/^[^-+]*{/ {
> > >  			if (in_map == 1) {
> > >  				sec=$(NF-1); in_sec=1;
> > >  			}
> > 
> > 
> > 
> > 
> 
> I don't think so.  The section name might get a + in front of it on lines like
> this:
> 
> +EXPERIMENTAL {
> 
> But the above change just skips matching on it, which I don't think is what we
> want.  The right fix I think would be to match on it, then strip the leading
> plus with a sed operation in the body of the match rule.
> 
> Neil
>