From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v2 2/3] bus/fslmc: ignore dpaax pa-va table
 errors
Date: Tue, 23 Oct 2018 09:44:20 +0000
Message-ID: <20181023094407.GB26188@jerin>
References: <20181017091151.15017-1-shreyansh.jain@nxp.com>
 <20181017100954.18284-1-shreyansh.jain@nxp.com>
 <20181017100954.18284-3-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "thomas@monjalon.net" <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0065.outbound.protection.outlook.com [104.47.41.65])
 by dpdk.org (Postfix) with ESMTP id 058F81B3E8
 for <dev@dpdk.org>; Tue, 23 Oct 2018 11:44:21 +0200 (CEST)
In-Reply-To: <20181017100954.18284-3-shreyansh.jain@nxp.com>
Content-Language: en-US
Content-ID: <E421DC4130AFCE45B71B4CA35369BE24@namprd07.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Wed, 17 Oct 2018 10:10:36 +0000
> From: Shreyansh Jain <shreyansh.jain@nxp.com>
> To: "thomas@monjalon.net" <thomas@monjalon.net>
> CC: "dev@dpdk.org" <dev@dpdk.org>, Shreyansh Jain <shreyansh.jain@nxp.com=
>
> Subject: [dpdk-dev] [PATCH v2 2/3] bus/fslmc: ignore dpaax pa-va table
>  errors
> x-mailer: git-send-email 2.17.1
>=20
>=20
> Presence of PA-VA Table is transparent to the drivers. Ignoring the
> return values from table update call.
>=20
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  drivers/bus/fslmc/fslmc_bus.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.=
c
> index 5ba5ce96b..db3026f4e 100644
> --- a/drivers/bus/fslmc/fslmc_bus.c
> +++ b/drivers/bus/fslmc/fslmc_bus.c
> @@ -386,11 +386,11 @@ rte_fslmc_probe(void)
>          * This has to be done before probe as some device initialization
>          * (during) probe allocate memory (dpaa2_sec) which needs to be p=
inned
>          * to this table.
> +        *
> +        * Error is ignored as relevant logs are handled within dpaax and
> +        * handling for unavailable dpaax table too is transparent to cal=
ler.
>          */
> -       ret =3D dpaax_iova_table_populate();
> -       if (ret) {
> -               DPAA2_BUS_WARN("PA->VA Translation table not available;")=
;
> -       }
> +       dpaax_iova_table_populate();
>=20
>         TAILQ_FOREACH(dev, &rte_fslmc_bus.device_list, next) {
>                 TAILQ_FOREACH(drv, &rte_fslmc_bus.driver_list, next) {
> --
> 2.17.1
>=20