From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v5 4/5] hash: add lock-free read-write
	concurrency
Date: Tue, 23 Oct 2018 12:52:51 +0100
Message-ID: <20181023115251.GD18800@bricha3-MOBL.ger.corp.intel.com>
References: <1540268524-126673-1-git-send-email-honnappa.nagarahalli@arm.com>
 <1540268524-126673-5-git-send-email-honnappa.nagarahalli@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org, yipeng1.wang@intel.com,
 gavin.hu@arm.com, dharmik.thakkar@arm.com, nd@arm.com
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id F20DE1B493
 for <dev@dpdk.org>; Tue, 23 Oct 2018 13:52:59 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1540268524-126673-5-git-send-email-honnappa.nagarahalli@arm.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Oct 22, 2018 at 11:22:03PM -0500, Honnappa Nagarahalli wrote:
> Add lock-free read-write concurrency. This is achieved by the
> following changes.
> 
> 1) Add memory ordering to avoid race conditions. The only race
> condition that can occur is -  using the key store element
> before the key write is completed. Hence, while inserting the element
> the release memory order is used. Any other race condition is caught
> by the key comparison. Memory orderings are added only where needed.
> For ex: reads in the writer's context do not need memory ordering
> as there is a single writer.
> 
> key_idx in the bucket entry and pdata in the key store element are
> used for synchronisation. key_idx is used to release an inserted
> entry in the bucket to the reader. Use of pdata for synchronisation
> is required due to updation of an existing entry where-in only
> the pdata is updated without updating key_idx.
> 
> 2) Reader-writer concurrency issue, caused by moving the keys
> to their alternative locations during key insert, is solved
> by introducing a global counter(tbl_chng_cnt) indicating a
> change in table.
> 
> 3) Add the flag to enable reader-writer concurrency during
> run time.
> 
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Ola Liljedahl <ola.liljedahl@arm.com>
> Reviewed-by: Steve Capper <steve.capper@arm.com>
> Reviewed-by: Yipeng Wang <yipeng1.wang@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>