From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: Change ether_addr to avoid conflict
Date: Wed, 24 Oct 2018 09:11:38 -0700
Message-ID: <20181024091138.132d78c5@xeon-e3>
References: <905F0B17-2987-4847-A054-C94501ACBC2D@perftech.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Lewis Donzis <lew@perftech.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com
 [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 75739683E
 for <dev@dpdk.org>; Wed, 24 Oct 2018 18:13:26 +0200 (CEST)
Received: by mail-pg1-f196.google.com with SMTP id a5-v6so1647497pgt.13
 for <dev@dpdk.org>; Wed, 24 Oct 2018 09:13:26 -0700 (PDT)
In-Reply-To: <905F0B17-2987-4847-A054-C94501ACBC2D@perftech.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 24 Oct 2018 07:35:28 -0500
Lewis Donzis <lew@perftech.com> wrote:

> Please consider changing "struct ether_addr" in rte_ether.h to "struct rte_ether_addr", in order to avoid conflicts with the same structure name /usr/include/net/ethernet.h.
> 
> Sometimes, there is need to include /usr/include/net/ethernet.h, but it conflicts with the same structure name in rte_ether.h.  Was there a reason this structure wasn't given the standard rte_ prefix?
> 
> Thanks,
> lew

Only history, remember EAL was first running on bare metal.

Changing to 'struct rte_ether_addr' breaks source of lots of applications.