From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v4 0/5] create different meson test targets
Date: Wed, 24 Oct 2018 11:43:28 +0100
Message-ID: <20181024104328.GC6128@bricha3-MOBL.ger.corp.intel.com>
References: <1539354799-21027-1-git-send-email-hari.kumarx.vemula@intel.com>
 <1540372032-28642-1-git-send-email-hari.kumarx.vemula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, reshma.pattan@intel.com
To: Hari kumar Vemula <hari.kumarx.vemula@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id A4C8C2C2F
 for <dev@dpdk.org>; Wed, 24 Oct 2018 12:43:33 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1540372032-28642-1-git-send-email-hari.kumarx.vemula@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Oct 24, 2018 at 10:07:07AM +0100, Hari kumar Vemula wrote:
> From: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
> 
> 1/5: remove existing test cases to reorganize further
> 2/5: add test-fast suite to meson targets
> 3/5: add test-perf suite to meson targets
> 4/5: add test-driver suite to meson targets
> 5/5: add test-dump suite to meson targets
> 
> --
> v4: Removed test from file prefix
> v3: Updated testcase names in file prefix option
> v2: Divided fast-test list into two lists
> --
> 
> Hari Kumar Vemula (5):
>   test: remove existing testcases for categorization
>   test: add quick run tests under test-fast suite
>   test: add performance tests under test-perf suite
>   test: add library dependent tests under test-driver suite
>   test: add dump test cases under test-dump suite
> 
>  test/test/meson.build | 288 ++++++++++++++++++++++++++++++--------------------
>  1 file changed, 174 insertions(+), 114 deletions(-)
> 
The idea looks good to me, I like it.

Couple of minor things I've pointed out on specific patches. The other
comment I have, is that I think the names would read better with the words
switched, and made plural i.e.

	test-fast ==> fast-tests
	test-perf ==> perf-tests
	test-driver ==> driver-tests

Not sure about "dump-tests", though, maybe "debug-tests" might be better?

The big issue that I see is that I think a lot of our tests are not as
reliable as we'd like. However, since that is unrelated to this set, with
the renames above and the comments on specific patches fixed:

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

PS: the series is not showing up properly in patchwork. Please check your
patch threading settings in git.