From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH v9 4/8] net/virtio: dump packed virtqueue data
Date: Thu, 25 Oct 2018 17:25:40 +0800
Message-ID: <20181025092539.GD22179@debian>
References: <20181024143236.21271-1-jfreimann@redhat.com>
 <20181024143236.21271-5-jfreimann@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com
To: Jens Freimann <jfreimann@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 4992B4C99
 for <dev@dpdk.org>; Thu, 25 Oct 2018 11:27:04 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20181024143236.21271-5-jfreimann@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Oct 24, 2018 at 04:32:32PM +0200, Jens Freimann wrote:
> Add support to dump packed virtqueue data to the
> VIRTQUEUE_DUMP() macro.
> 
> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  drivers/net/virtio/virtqueue.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
> index 3d512fe30..2af1bc259 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -368,6 +368,15 @@ virtqueue_notify(struct virtqueue *vq)
>  	uint16_t used_idx, nused; \
>  	used_idx = (vq)->vq_ring.used->idx; \
>  	nused = (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \
> +	if (vtpci_packed_queue((vq)->hw)) { \
> +	  PMD_INIT_LOG(DEBUG, \
> +	  "VQ: - size=%d; free=%d; used_cons_idx=%d; avail_idx=%d;" \
> +          "VQ: - avail_wrap_counter=%d; used_wrap_counter=%d", \

Please remove the second "VQ: -" as they are on the same line.

> +	  (vq)->vq_nentries, (vq)->vq_free_cnt, (vq)->vq_used_cons_idx, \
> +	  (vq)->vq_avail_idx, (vq)->vq_ring.avail_wrap_counter, \
> +	  (vq)->vq_ring.used_wrap_counter); \
> +	  break; \
> +	} \
>  	PMD_INIT_LOG(DEBUG, \
>  	  "VQ: - size=%d; free=%d; used=%d; desc_head_idx=%d;" \
>  	  " avail.idx=%d; used_cons_idx=%d; used.idx=%d;" \
> -- 
> 2.17.1
>