From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darek Stojaczyk Subject: [PATCH] eal: fix rte_mp_request_sync() memleak on device hotplug Date: Thu, 25 Oct 2018 12:46:19 +0200 Message-ID: <20181025104619.137205-1-dariusz.stojaczyk@intel.com> Cc: Darek Stojaczyk , qi.z.zhang@intel.com, stable@dpdk.org To: dev@dpdk.org Return-path: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_mp_request_sync() says that the caller is responsible for freeing one of its parameters afterwards. EAL didn't do that, causing a memory leak. Fixes: 244d5130719c ("eal: enable hotplug on multi-process") Cc: qi.z.zhang@intel.com Cc: stable@dpdk.org Signed-off-by: Darek Stojaczyk --- lib/librte_eal/common/hotplug_mp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/hotplug_mp.c b/lib/librte_eal/common/hotplug_mp.c index 84f59d95b..9a6a88546 100644 --- a/lib/librte_eal/common/hotplug_mp.c +++ b/lib/librte_eal/common/hotplug_mp.c @@ -355,6 +355,7 @@ int eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req) resp = (struct eal_dev_mp_req *)mp_reply.msgs[0].param; req->result = resp->result; + free(mp_reply.msgs); return ret; } @@ -397,6 +398,7 @@ int eal_dev_hotplug_request_to_secondary(struct eal_dev_mp_req *req) } } + free(mp_reply.msgs); return 0; } -- 2.17.1