From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darek Stojaczyk Subject: [PATCH] vdev: fix rte_mp_request_sync() memleak on scan Date: Thu, 25 Oct 2018 12:47:35 +0200 Message-ID: <20181025104735.137381-1-dariusz.stojaczyk@intel.com> Cc: anatoly.burakov@intel.com, Darek Stojaczyk , jianfeng.tan@intel.com, qi.z.zhang@intel.com, stable@dpdk.org, Paul Luse To: dev@dpdk.org Return-path: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_mp_request_sync() says that the caller is responsible for freeing one of its parameters afterwards. vdev didn't do that, causing a memory leak. Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel") Cc: jianfeng.tan@intel.com Cc: qi.z.zhang@intel.com Cc: stable@dpdk.org Signed-off-by: Paul Luse Signed-off-by: Darek Stojaczyk --- drivers/bus/vdev/vdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index 688e31c21..685cc4e78 100644 --- a/drivers/bus/vdev/vdev.c +++ b/drivers/bus/vdev/vdev.c @@ -425,6 +425,7 @@ vdev_scan(void) mp_rep = &mp_reply.msgs[0]; resp = (struct vdev_param *)mp_rep->param; VDEV_LOG(INFO, "Received %d vdevs", resp->num); + free(mp_reply.msgs); } else VDEV_LOG(ERR, "Failed to request vdev from primary"); -- 2.17.1