From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiaolong Ye Subject: [PATCH 2/2] net/i40e: correct offload not supported mask Date: Fri, 26 Oct 2018 14:33:14 +0800 Message-ID: <20181026063314.100992-1-xiaolong.ye@intel.com> Cc: dev@dpdk.org, Xiaolong Ye , tomaszx.kulasek@intel.com To: Qi Zhang , Beilei Xing Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 2320A5F0F for ; Fri, 26 Oct 2018 08:33:30 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Just as the name I40E_TX_OFFLOAD_NOTSUP_MASK indicates, it should be the mask of unsupported features (either not in PKT_TX_OFFLOAD_MASK or in I40E_TX_OFFLOAD_MASK), however, xor will not get desired result here, assume bit 0 of PKT_TX_OFFLOAD_MASK and I40E_TX_OFFLOAD_MAKS are 0 which means corresponding feature is not supported in both sides, then we get value of bit 0 of I40E_TX_OFFLOAD_NOTSUP_MASK which is 0 via xor, it implies that it is supported which doesn't meet our expectation. Correct it by a NOT-AND operation. Fixes: 3f33e643e5c6 ("net/i40e: add Tx preparation") Cc: tomaszx.kulasek@intel.com Signed-off-by: Xiaolong Ye --- drivers/net/i40e/i40e_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 8bfa25178..e76412207 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -69,7 +69,7 @@ I40E_TX_IEEE1588_TMST) #define I40E_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & I40E_TX_OFFLOAD_MASK) static inline void i40e_rxd_to_vlan_tci(struct rte_mbuf *mb, volatile union i40e_rx_desc *rxdp) -- 2.17.1