From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH] compress/qat: fix out-of-bounds error Date: Wed, 31 Oct 2018 06:35:11 +0000 Message-ID: <20181031063503.GA21779@jerin> References: <20181027164739.13110-1-jerin.jacob@caviumnetworks.com> <1540946394-22196-1-git-send-email-fiona.trahe@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "thomas@monjalon.net" , "akhil.goyal@nxp.com" , "tomaszx.jozwiak@intel.com" To: Fiona Trahe Return-path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0048.outbound.protection.outlook.com [104.47.38.48]) by dpdk.org (Postfix) with ESMTP id 1C4F4DED for ; Wed, 31 Oct 2018 07:35:13 +0100 (CET) In-Reply-To: <1540946394-22196-1-git-send-email-fiona.trahe@intel.com> Content-Language: en-US Content-ID: <5D7F6B2228ADDA4B96406ADCC6CDC627@namprd07.prod.outlook.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Wed, 31 Oct 2018 00:39:54 +0000 > From: Fiona Trahe > To: dev@dpdk.org > CC: thomas@monjalon.net, akhil.goyal@nxp.com, tomaszx.jozwiak@intel.com, > jerin.jacob@caviumnetworks.com, Fiona Trahe > Subject: [PATCH] compress/qat: fix out-of-bounds error > X-Mailer: git-send-email 1.7.0.7 >=20 >=20 > QAT array for sgls in intermediate buffer structure > was #defined to 1, but setup code hardcoded as if 2 buffers > so causing out of bounds write. Reworked to loop correctly > using #define. >=20 > Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding") >=20 > Reported-by: Jerin Jacob > Signed-off-by: Fiona Trahe clang build is not reproducible with this patch. Tested-by: Jerin Jacob