From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH] devtools: check wrong svg include in patches Date: Wed, 31 Oct 2018 12:05:48 +0100 Message-ID: <20181031110548.31184-1-thomas@monjalon.net> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: john.mcnamara@intel.com, marko.kovacevic@intel.com, Arnon Warshavsky To: dev@dpdk.org Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 22A74B62 for ; Wed, 31 Oct 2018 12:05:59 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Including svg files with the svg extension is a common mistake: .. figure:: example.svg must be .. figure:: example.* So it will work also when building pdf doc with figures converted to png files. A check is added in checkpatches.sh. Signed-off-by: Thomas Monjalon PS: it seems this check is not working. Arnon, I need your help please. Cc: Arnon Warshavsky --- devtools/checkpatches.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index bf3114f95..e69b5bc34 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -50,6 +50,12 @@ check_forbidden_additions() { -v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \ -v RET_ON_FAIL=1 \ -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk - + # svg figures must be included with wildcard extension + # because of png conversion for pdf docs + awk -v FOLDERS='doc' \ + -v EXPRESSIONS=':: *[^ ]*\\.svg' \ + -v RET_ON_FAIL=1 \ + -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk - } number=0 -- 2.19.0