From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v5 1/3] net/failsafe: remove D_XOPEN_SOURCE
 flag
Date: Wed, 31 Oct 2018 22:10:39 +0100
Message-ID: <20181031211039.weuadluvjobssqbn@bidouze.vm.6wind.com>
References: <20181031021758.66752-1-doucette@bu.edu>
 <20181031021758.66752-2-doucette@bu.edu> <1585740.4slmyqDWMi@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, Cody Doucette <doucette@bu.edu>,
 Matan Azrad <matan@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com
 [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 11B32DED
 for <dev@dpdk.org>; Wed, 31 Oct 2018 22:11:01 +0100 (CET)
Received: by mail-wm1-f67.google.com with SMTP id p2-v6so15747353wmc.2
 for <dev@dpdk.org>; Wed, 31 Oct 2018 14:11:01 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1585740.4slmyqDWMi@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Oct 31, 2018 at 06:02:29PM +0100, Thomas Monjalon wrote:
> 31/10/2018 03:17, Cody Doucette:
> > Compilation flag D_XOPEN_SOURCE is causing failsafe to fail to
> > build when changing some DPDK libraries. The flag is not needed
> > and therefore is removed.
> > 
> > Signed-off-by: Cody Doucette <doucette@bu.edu>
> 
> Gaetan, please approve that the flag is not needed.
> 

I suspected popen or fgets from failsafe_args.c, but I wasn't able
to find a reason for the define. I can't remember the initial reason for
it, sorry.

I have tested the build on linux and freebsd, without issue, so at this
point I think this is ok.

-- 
Gaëtan Rivet
6WIND