From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() Date: Thu, 1 Nov 2018 09:53:56 -0400 Message-ID: <20181101135356.GA27151@hmswarspite.think-freely.org> References: <20180727135243.147744-1-doucette@bu.edu> <20181031150330.GA14228@neilslaptop.think-freely.org> <9016909.uyicx2EDCj@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Cody Doucette , "Ananyev, Konstantin" , dev@dpdk.org, Gaetan Rivet , Olivier Matz , "Dumitrescu, Cristian" , Michel Machado , "Fu, Qiaobin" To: Thomas Monjalon Return-path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 30D361B394 for ; Thu, 1 Nov 2018 14:54:47 +0100 (CET) Content-Disposition: inline In-Reply-To: <9016909.uyicx2EDCj@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 31, 2018 at 04:08:18PM +0100, Thomas Monjalon wrote: > 31/10/2018 16:03, Neil Horman: > > On Wed, Oct 31, 2018 at 10:20:46AM -0400, Cody Doucette wrote: > > > Thanks for the suggestion. It looks like > > > 49bcce138374458d1edd1c50d8e5726959108ef4 is already in my tree. I tried > > > applying and checking again anyway and it seems that the error is still > > > present. > > > > > Thats not a commit in the upstream tree, I've no idea what patch you are referring to > > Yes it is in the tree, in 18.11-rc1. > Got it now, thanks. So this actually looks to be a new bug, and I'm not sure how it got in there. The awk match to close the in_map section isn't triggering on this patch set, which is very odd, as Its been working. The match is ^(map) which should be ok (allbeit perl regex syntax), which I thought awk supported. That said, it certainly doesn't seem to be matching now. I've got a patch posted to you which replaces this with a traditional character class match [^map], and thats working with this patch set. Neil