From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v7 4/5] hash: add lock-free read-write
 concurrency
Date: Tue, 6 Nov 2018 09:47:29 +0000
Message-ID: <20181106094715.GA12863@jerin>
References: <1540532253-112591-1-git-send-email-honnappa.nagarahalli@arm.com>
 <AM6PR08MB3672DD10D2BEAEB58599B7BD98CB0@AM6PR08MB3672.eurprd08.prod.outlook.com>
 <20181106090953.GA5671@jerin> <4202399.UOW9WdkMPh@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "yipeng1.wang@intel.com"
 <yipeng1.wang@intel.com>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>, "Gavin
 Hu (Arm Technology China)" <Gavin.Hu@arm.com>, nd <nd@arm.com>,
 "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "hemant.agrawal@nxp.com"
 <hemant.agrawal@nxp.com>, "chaozhu@linux.vnet.ibm.com"
 <chaozhu@linux.vnet.ibm.com>, "Kapoor, Prasun" <Prasun.Kapoor@cavium.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0061.outbound.protection.outlook.com [104.47.36.61])
 by dpdk.org (Postfix) with ESMTP id 9DB302862
 for <dev@dpdk.org>; Tue,  6 Nov 2018 10:47:31 +0100 (CET)
In-Reply-To: <4202399.UOW9WdkMPh@xps>
Content-Language: en-US
Content-ID: <8551B1477203B342A0BAAF182FA87C25@namprd07.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Tue, 06 Nov 2018 10:13:53 +0100
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
>  "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
>  "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
>  "dev@dpdk.org" <dev@dpdk.org>, "yipeng1.wang@intel.com"
>  <yipeng1.wang@intel.com>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
>  "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, nd <nd@arm.com>,
>  "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
>  "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
>  "chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>, "Kapoor,
>  Prasun" <Prasun.Kapoor@cavium.com>
> Subject: Re: [dpdk-dev] [PATCH v7 4/5] hash: add lock-free read-write
>  concurrency
>=20
> 06/11/2018 10:10, Jerin Jacob:
> > From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> > > Jerin, thank you for running this test and all the analysis. I have n=
ot run this test. I was focused on simultaneous reads and writes. You can l=
ook at file test_hash_readwrite_lf.c to look for the kind of the use cases.
> > >
> > > I am trying to reproduce this, I will get back with more details soon=
.
> >
> > OK. Since RC2 approaching, bit worried about next steps if we cannot
> > avoid the regression with this new feature for this release.
>=20
> 18.11-rc2 is already out.
>=20
> > 24% drop of performance regression not seen in past for a specific
> > usecase.So not sure what we did past for similar situations.
> >
> > Thomas,
> > Any thought of this?
>=20
> Everything is possible, you just need to agree on a patch.
> Please let's fix (or disable or revert) it in -rc3 this week.

I let Honnappa to decide fix, disable or revert action for rc3 release.
But it should either one of them for rc3 not this patch as is.

>=20
>=20